<pre style='margin:0'>
Rainer Müller (raimue) pushed a commit to branch master
in repository trac.macports.org.
</pre>
<p><a href="https://github.com/macports/trac.macports.org/commit/2cfaff73ab60dbbbbc7c885f176642a6e40d8c69">https://github.com/macports/trac.macports.org/commit/2cfaff73ab60dbbbbc7c885f176642a6e40d8c69</a></p>
<pre style="white-space: pre; background: #F8F8F8">The following commit(s) were added to refs/heads/master by this push:
<span style='display:block; white-space:pre;color:#404040;'> new 2cfaff7 trac-github-update: correct comment about emails
</span>2cfaff7 is described below
<span style='display:block; white-space:pre;color:#808000;'>commit 2cfaff73ab60dbbbbc7c885f176642a6e40d8c69
</span>Author: Rainer Müller <raimue@macports.org>
AuthorDate: Sun Nov 6 04:11:30 2016 +0100
<span style='display:block; white-space:pre;color:#404040;'> trac-github-update: correct comment about emails
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> SPF only validates the envelope address, the problem would be DMARC.
</span>---
plugins/hooks/trac-github-update.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
<span style='display:block; white-space:pre;color:#808080;'>diff --git a/plugins/hooks/trac-github-update.py b/plugins/hooks/trac-github-update.py
</span><span style='display:block; white-space:pre;color:#808080;'>index 320b9e2..38add27 100755
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>--- a/plugins/hooks/trac-github-update.py
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>+++ b/plugins/hooks/trac-github-update.py
</span><span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -85,7 +85,7 @@ class GitHubWebhookEnvironment(GenericEnvironment):
</span> name = self._github.get_user(login).name or login
# GitHub only lists the primary email address in the payload. We do not
# want to expose it to the public, and sending with these addresses
<span style='display:block; white-space:pre;background:#ffe0e0;'>- # would also violate SPF. Use a static sender email instead.
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ # would also violate DMARC. Use a static sender email instead.
</span> email = "%s@users.noreply.github.com" % (login,)
self._pusher_email = "%s <%s>" % (name, email)
return self._pusher_email.encode('utf-8')
</pre><pre style='margin:0'>
</pre>