<pre style='margin:0'>
MarcusCalhoun-Lopez pushed a commit to branch master
in repository macports-ports.
</pre>
<p><a href="https://github.com/macports/macports-ports/commit/5aba96dcfb4d20c2336e452990cf3bc5d20e8efc">https://github.com/macports/macports-ports/commit/5aba96dcfb4d20c2336e452990cf3bc5d20e8efc</a></p>
<pre style="white-space: pre; background: #F8F8F8"><span style='display:block; white-space:pre;color:#808000;'>commit 5aba96dcfb4d20c2336e452990cf3bc5d20e8efc
</span>Author: Marcus Calhoun-Lopez <mcalhoun@macports.org>
AuthorDate: Sat Dec 31 11:10:33 2016 -0700
<span style='display:block; white-space:pre;color:#404040;'> qmake5 PG: set all Qt variables in pre-configure
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> Delay setting Qt variables with values from,
</span><span style='display:block; white-space:pre;color:#404040;'> e.g. macosx_deployment_target, as much as possible so that Portfile
</span><span style='display:block; white-space:pre;color:#404040;'> may modify values if desired.
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> see comments in https://github.com/macports/macports-ports/commit/e43ac6fe071206a0346ed5f05a7686f1735c12e9#commitcomment-20334045
</span>---
_resources/port1.0/group/qmake5-1.0.tcl | 38 +++++++++++++++------------------
1 file changed, 17 insertions(+), 21 deletions(-)
<span style='display:block; white-space:pre;color:#808080;'>diff --git a/_resources/port1.0/group/qmake5-1.0.tcl b/_resources/port1.0/group/qmake5-1.0.tcl
</span><span style='display:block; white-space:pre;color:#808080;'>index 62d386f..f8eba5d 100644
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>--- a/_resources/port1.0/group/qmake5-1.0.tcl
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>+++ b/_resources/port1.0/group/qmake5-1.0.tcl
</span><span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -88,22 +88,20 @@ pre-configure {
</span> QMAKE_LFLAGS+="-arch x86_64"
}
}
<span style='display:block; white-space:pre;background:#ffe0e0;'>-}
</span>
<span style='display:block; white-space:pre;background:#ffe0e0;'>-# override QMAKE_MACOSX_DEPLOYMENT_TARGET set in ${prefix}/libexec/qt5/mkspecs/macx-clang/qmake.conf
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-# see #50249
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-configure.args-append QMAKE_MACOSX_DEPLOYMENT_TARGET=${macosx_deployment_target}
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ # override QMAKE_MACOSX_DEPLOYMENT_TARGET set in ${prefix}/libexec/qt5/mkspecs/macx-clang/qmake.conf
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ # see #50249
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ configure.args-append QMAKE_MACOSX_DEPLOYMENT_TARGET=${macosx_deployment_target}
</span>
<span style='display:block; white-space:pre;background:#ffe0e0;'>-# respect configure.sdkroot if it exists
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-if {${configure.sdkroot} ne ""} {
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- configure.args-append \
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- QMAKE_MAC_SDK=[string tolower [join [lrange [split [lindex [split ${configure.sdkroot} "/"] end] "."] 0 end-1] "."]]
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-}
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ # respect configure.sdkroot if it exists
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if {${configure.sdkroot} ne ""} {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ configure.args-append \
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ QMAKE_MAC_SDK=[string tolower [join [lrange [split [lindex [split ${configure.sdkroot} "/"] end] "."] 0 end-1] "."]]
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ }
</span>
<span style='display:block; white-space:pre;background:#ffe0e0;'>-# a change in Qt 5.7.1 made it more difficult to override sdk variables
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-# see https://codereview.qt-project.org/#/c/165499/
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-# see https://bugreports.qt.io/browse/QTBUG-56965
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-post-extract {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ # a change in Qt 5.7.1 made it more difficult to override sdk variables
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ # see https://codereview.qt-project.org/#/c/165499/
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ # see https://bugreports.qt.io/browse/QTBUG-56965
</span> set cache [open "${worksrcpath}/.qmake.cache" w 0644]
puts ${cache} "QMAKE_MACOSX_DEPLOYMENT_TARGET=${macosx_deployment_target}"
if {${configure.sdkroot} ne ""} {
<span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -111,16 +109,14 @@ post-extract {
</span> QMAKE_MAC_SDK=[string tolower [join [lrange [split [lindex [split ${configure.sdkroot} "/"] end] "."] 0 end-1] "."]]
}
close ${cache}
<span style='display:block; white-space:pre;background:#ffe0e0;'>-}
</span>
<span style='display:block; white-space:pre;background:#ffe0e0;'>-# respect configure.compiler but still allow qmake to find correct Xcode clang based on SDK
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-if { ${configure.compiler} ne "clang" } {
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- configure.args-append \
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- QMAKE_CC=${configure.cc} \
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- QMAKE_CXX=${configure.cxx}
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-}
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ # respect configure.compiler but still allow qmake to find correct Xcode clang based on SDK
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if { ${configure.compiler} ne "clang" } {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ configure.args-append \
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ QMAKE_CC=${configure.cc} \
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ QMAKE_CXX=${configure.cxx}
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ }
</span>
<span style='display:block; white-space:pre;background:#ffe0e0;'>-pre-configure {
</span> set qt_version [exec ${prefix}/bin/pkg-config --modversion Qt5Core]
if { [vercmp ${qt_version} 5.6.0] >= 0 } {
</pre><pre style='margin:0'>
</pre>