<pre style='margin:0'>
Rainer Müller (raimue) pushed a commit to branch master
in repository macports-base.
</pre>
<p><a href="https://github.com/macports/macports-base/commit/09eacc47fd3c6d96687476b3873549dc87fe90c2">https://github.com/macports/macports-base/commit/09eacc47fd3c6d96687476b3873549dc87fe90c2</a></p>
<pre style="white-space: pre; background: #F8F8F8"><span style='display:block; white-space:pre;color:#808000;'>commit 09eacc47fd3c6d96687476b3873549dc87fe90c2
</span>Author: Rainer Müller <raimue@macports.org>
AuthorDate: Fri Oct 6 16:15:53 2017 +0200
<span style='display:block; white-space:pre;color:#404040;'> diagnose: No check if $prefix/bin is first in PATH
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> Do not check whether ${prefix}/bin is first in PATH, as it is a valid
</span><span style='display:block; white-space:pre;color:#404040;'> configuration to have other paths such as ~/bin in front. I cannot see
</span><span style='display:block; white-space:pre;color:#404040;'> problems with that for the future, so this warning is misleading.
</span>---
src/macports1.0/diagnose.tcl | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
<span style='display:block; white-space:pre;color:#808080;'>diff --git a/src/macports1.0/diagnose.tcl b/src/macports1.0/diagnose.tcl
</span><span style='display:block; white-space:pre;color:#808080;'>index 20705ba..567a2ab 100644
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>--- a/src/macports1.0/diagnose.tcl
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>+++ b/src/macports1.0/diagnose.tcl
</span><span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -693,16 +693,8 @@ namespace eval diagnose {
</span> set path ${macports::user_path}
set split [split $path :]
<span style='display:block; white-space:pre;background:#ffe0e0;'>- if {"$port_loc/bin" in $split && "$port_loc/sbin" in $split} {
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- if {[lindex $split 0] ne "$port_loc/bin"} {
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- ui_warn "$port_loc/bin is not first in your PATH environment variable. This may or may not \
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- cause problems in the future."
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- }
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- return
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- } else {
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- ui_warn "your \$PATH environment variable does not currently include $port_loc/bin, which is where port is located."
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if {"$port_loc/bin" ni $split || "$port_loc/sbin" ni $split} {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ ui_warn "Your \$PATH environment variable does not currently include $port_loc/bin or $port_loc/sbin"
</span>
# XXX Only works for bash. Should set default profile_path based on the shell.
if {[info exists macports::ui_options(questions_yesno)] && $shell_name eq "bash"} {
</pre><pre style='margin:0'>
</pre>