<pre style='margin:0'>
Rainer Müller (raimue) pushed a commit to branch master
in repository macports-base.
</pre>
<p><a href="https://github.com/macports/macports-base/commit/8525b9c18d67db7e100f3a71161a185510163b38">https://github.com/macports/macports-base/commit/8525b9c18d67db7e100f3a71161a185510163b38</a></p>
<pre style="white-space: pre; background: #F8F8F8">The following commit(s) were added to refs/heads/master by this push:
<span style='display:block; white-space:pre;color:#404040;'> new 8525b9c rev-upgrade: Always check for wrong cxx_stdlib
</span>8525b9c is described below
<span style='display:block; white-space:pre;color:#808000;'>commit 8525b9c18d67db7e100f3a71161a185510163b38
</span>Author: Rainer Müller <raimue@macports.org>
AuthorDate: Fri Apr 20 11:39:12 2018 +0200
<span style='display:block; white-space:pre;color:#404040;'> rev-upgrade: Always check for wrong cxx_stdlib
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> rev-upgrade would only check for cxx_stdlib when at least one broken
</span><span style='display:block; white-space:pre;color:#404040;'> file was found. Do not return early, but always run the cxx_stdlib
</span><span style='display:block; white-space:pre;color:#404040;'> check.
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> See: https://trac.macports.org/ticket/56326
</span>---
src/macports1.0/macports.tcl | 30 ++++++++++++++++++------------
1 file changed, 18 insertions(+), 12 deletions(-)
<span style='display:block; white-space:pre;color:#808080;'>diff --git a/src/macports1.0/macports.tcl b/src/macports1.0/macports.tcl
</span><span style='display:block; white-space:pre;color:#808080;'>index 52f554f..8d04ba3 100644
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>--- a/src/macports1.0/macports.tcl
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>+++ b/src/macports1.0/macports.tcl
</span><span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -4909,22 +4909,23 @@ proc macports::revupgrade_scanandrebuild {broken_port_counts_name opts} {
</span> set num_broken_files [llength $broken_files]
set s [expr {$num_broken_files == 1 ? "" : "s"}]
<span style='display:block; white-space:pre;background:#e0ffe0;'>+ set broken_ports {}
</span> if {$num_broken_files == 0} {
ui_msg "$macports::ui_prefix No broken files found."
<span style='display:block; white-space:pre;background:#ffe0e0;'>- return 0
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- }
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- ui_msg "$macports::ui_prefix Found $num_broken_files broken file${s}, matching files to ports"
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- set broken_ports {}
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- set broken_files [lsort -unique $broken_files]
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- foreach file $broken_files {
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- set port [registry::entry owner $file]
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- if {$port ne ""} {
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- lappend broken_ports $port
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- lappend broken_files_by_port($port) $file
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- } else {
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- ui_error "Broken file $file doesn't belong to any port."
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ } else {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ ui_msg "$macports::ui_prefix Found $num_broken_files broken file${s}, matching files to ports"
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ set broken_files [lsort -unique $broken_files]
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ foreach file $broken_files {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ set port [registry::entry owner $file]
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if {$port ne ""} {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ lappend broken_ports $port
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ lappend broken_files_by_port($port) $file
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ } else {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ ui_error "Broken file $file doesn't belong to any port."
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ }
</span> }
}
<span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span> # check for mismatched cxx_stdlib
if {${macports::cxx_stdlib} eq "libc++"} {
set wrong_stdlib libstdc++
<span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -4937,6 +4938,11 @@ proc macports::revupgrade_scanandrebuild {broken_port_counts_name opts} {
</span> }
set broken_ports [lsort -unique [concat $broken_ports $broken_cxx_ports]]
<span style='display:block; white-space:pre;background:#e0ffe0;'>+ if {[llength $broken_ports] == 0} {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ ui_msg "$macports::ui_prefix No broken ports found."
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ return 0
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ }
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span> if {$macports::revupgrade_mode eq "rebuild"} {
# don't try to rebuild ports that don't exist in the tree
set temp_broken_ports {}
</pre><pre style='margin:0'>
</pre>