<pre style='margin:0'>
Ryan Schmidt (ryandesign) pushed a commit to branch master
in repository macports-ports.
</pre>
<p><a href="https://github.com/macports/macports-ports/commit/4f9c2bda66493117326c6e0a9bdf5222747d3686">https://github.com/macports/macports-ports/commit/4f9c2bda66493117326c6e0a9bdf5222747d3686</a></p>
<pre style="white-space: pre; background: #F8F8F8">The following commit(s) were added to refs/heads/master by this push:
<span style='display:block; white-space:pre;color:#404040;'> new 4f9c2bd VisualBoyAdvance: Fix more build failures
</span>4f9c2bd is described below
<span style='display:block; white-space:pre;color:#808000;'>commit 4f9c2bda66493117326c6e0a9bdf5222747d3686
</span>Author: Ryan Schmidt <ryandesign@macports.org>
AuthorDate: Sun Oct 7 22:40:08 2018 -0500
<span style='display:block; white-space:pre;color:#404040;'> VisualBoyAdvance: Fix more build failures
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> Closes: https://trac.macports.org/ticket/37561
</span>---
emulators/VisualBoyAdvance/Portfile | 5 +-
emulators/VisualBoyAdvance/files/const-char.patch | 100 ++++++++++++++++++++++
emulators/VisualBoyAdvance/files/debugger.patch | 5 ++
emulators/VisualBoyAdvance/files/gzwrite.patch | 14 +++
emulators/VisualBoyAdvance/files/libpng-1.4.patch | 14 +++
5 files changed, 137 insertions(+), 1 deletion(-)
<span style='display:block; white-space:pre;color:#808080;'>diff --git a/emulators/VisualBoyAdvance/Portfile b/emulators/VisualBoyAdvance/Portfile
</span><span style='display:block; white-space:pre;color:#808080;'>index be511fb..b45aa70 100644
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>--- a/emulators/VisualBoyAdvance/Portfile
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>+++ b/emulators/VisualBoyAdvance/Portfile
</span><span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -28,7 +28,10 @@ master_sites sourceforge:project/vba/${name}/${version}
</span> depends_lib port:libsdl \
port:libpng
<span style='display:block; white-space:pre;background:#ffe0e0;'>-patchfiles debugger.patch
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+patchfiles-append const-char.patch
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+patchfiles-append debugger.patch
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+patchfiles-append gzwrite.patch
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+patchfiles-append libpng-1.4.patch
</span>
configure.cxxflags-append \
-I${prefix}/include
<span style='display:block; white-space:pre;color:#808080;'>diff --git a/emulators/VisualBoyAdvance/files/const-char.patch b/emulators/VisualBoyAdvance/files/const-char.patch
</span>new file mode 100644
<span style='display:block; white-space:pre;color:#808080;'>index 0000000..24587eb
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>--- /dev/null
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>+++ b/emulators/VisualBoyAdvance/files/const-char.patch
</span><span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -0,0 +1,100 @@
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+Use const char where needed. Taken from an upstream commit, as seen in
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+this GitHub mirror's commit:
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+https://github.com/x3ro/VisualBoyAdvance/commit/722a30419a30345be3c2ebf6ef85689067ea7005
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+--- src/GBA.cpp.orig 2004-05-13 09:37:59.000000000 -0500
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++++ src/GBA.cpp 2018-10-07 22:14:50.000000000 -0500
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+@@ -1130,7 +1130,7 @@
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ bool CPUIsZipFile(const char * file)
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if(strlen(file) > 4) {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+- char * p = strrchr(file,'.');
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++ const char * p = strrchr(file,'.');
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if(p != NULL) {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if(_stricmp(p, ".zip") == 0)
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+@@ -1145,7 +1145,7 @@
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ cpuIsMultiBoot = false;
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if(strlen(file) > 4) {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+- char * p = strrchr(file,'.');
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++ const char * p = strrchr(file,'.');
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if(p != NULL) {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if(_stricmp(p, ".gba") == 0)
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+@@ -1169,7 +1169,7 @@
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ bool CPUIsGBABios(const char * file)
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if(strlen(file) > 4) {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+- char * p = strrchr(file,'.');
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++ const char * p = strrchr(file,'.');
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if(p != NULL) {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if(_stricmp(p, ".gba") == 0)
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+@@ -1189,7 +1189,7 @@
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ bool CPUIsELF(const char *file)
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if(strlen(file) > 4) {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+- char * p = strrchr(file,'.');
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++ const char * p = strrchr(file,'.');
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if(p != NULL) {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if(_stricmp(p, ".elf") == 0)
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+--- src/Util.cpp.orig 2004-05-20 12:42:37.000000000 -0500
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++++ src/Util.cpp 2018-10-07 22:21:03.000000000 -0500
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+@@ -478,7 +478,7 @@
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ cpuIsMultiBoot = false;
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if(strlen(file) > 4) {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+- char * p = strrchr(file,'.');
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++ const char * p = strrchr(file,'.');
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if(p != NULL) {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if(_stricmp(p, ".gba") == 0)
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+@@ -502,7 +502,7 @@
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ bool utilIsGBImage(const char * file)
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if(strlen(file) > 4) {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+- char * p = strrchr(file,'.');
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++ const char * p = strrchr(file,'.');
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if(p != NULL) {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if(_stricmp(p, ".gb") == 0)
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+@@ -522,7 +522,7 @@
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ bool utilIsZipFile(const char *file)
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if(strlen(file) > 4) {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+- char * p = strrchr(file,'.');
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++ const char * p = strrchr(file,'.');
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if(p != NULL) {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if(_stricmp(p, ".zip") == 0)
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+@@ -537,7 +537,7 @@
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ bool utilIsRarFile(const char *file)
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if(strlen(file) > 4) {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+- char * p = strrchr(file,'.');
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++ const char * p = strrchr(file,'.');
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if(p != NULL) {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if(_stricmp(p, ".rar") == 0)
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+@@ -552,7 +552,7 @@
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ bool utilIsGzipFile(const char *file)
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if(strlen(file) > 3) {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+- char * p = strrchr(file,'.');
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++ const char * p = strrchr(file,'.');
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if(p != NULL) {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if(_stricmp(p, ".gz") == 0)
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+--- src/gb/GB.cpp.orig 2004-05-13 14:35:26.000000000 -0500
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++++ src/gb/GB.cpp 2018-10-07 22:17:32.000000000 -0500
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+@@ -567,7 +567,7 @@
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ bool gbIsGameboyRom(char * file)
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if(strlen(file) > 4) {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+- char * p = strrchr(file,'.');
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++ const char * p = strrchr(file,'.');
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if(p != NULL) {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if(_stricmp(p, ".gb") == 0)
</span><span style='display:block; white-space:pre;color:#808080;'>diff --git a/emulators/VisualBoyAdvance/files/debugger.patch b/emulators/VisualBoyAdvance/files/debugger.patch
</span><span style='display:block; white-space:pre;color:#808080;'>index 9031c21..75c3542 100644
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>--- a/emulators/VisualBoyAdvance/files/debugger.patch
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>+++ b/emulators/VisualBoyAdvance/files/debugger.patch
</span><span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -1,5 +1,10 @@
</span> Don't conflate two different variables named "i" and two different
variables named "n". Clang errors on these variable redefinitions.
<span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+The "i" variable part of this patch is equivalent to what was done
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+upstream, as seen in this GitHub mirror's commit:
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+https://github.com/x3ro/VisualBoyAdvance/commit/722a30419a30345be3c2ebf6ef85689067ea7005
</span> --- src/sdl/debugger.cpp.orig 2004-05-13 09:13:14.000000000 -0500
+++ src/sdl/debugger.cpp 2018-10-07 21:32:20.000000000 -0500
@@ -1275,12 +1275,12 @@
<span style='display:block; white-space:pre;color:#808080;'>diff --git a/emulators/VisualBoyAdvance/files/gzwrite.patch b/emulators/VisualBoyAdvance/files/gzwrite.patch
</span>new file mode 100644
<span style='display:block; white-space:pre;color:#808080;'>index 0000000..b34dfbe
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>--- /dev/null
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>+++ b/emulators/VisualBoyAdvance/files/gzwrite.patch
</span><span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -0,0 +1,14 @@
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+Fix wrong usage of gzwrite
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+https://github.com/x3ro/VisualBoyAdvance/pull/1/commits/8b5249d58edded5c8e4b2439eef7b46fabd59a36
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+--- src/Util.cpp.orig 2004-05-20 12:42:37.000000000 -0500
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++++ src/Util.cpp 2018-10-07 22:34:37.000000000 -0500
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+@@ -984,7 +984,7 @@
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ gzFile utilGzOpen(const char *file, const char *mode)
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+- utilGzWriteFunc = (int (*)(void *,void * const, unsigned int))gzwrite;
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++ utilGzWriteFunc = (int (*)(gzFile,void * const, unsigned int))gzwrite;
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ utilGzReadFunc = gzread;
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ utilGzCloseFunc = gzclose;
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;color:#808080;'>diff --git a/emulators/VisualBoyAdvance/files/libpng-1.4.patch b/emulators/VisualBoyAdvance/files/libpng-1.4.patch
</span>new file mode 100644
<span style='display:block; white-space:pre;color:#808080;'>index 0000000..8dbfe00
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>--- /dev/null
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>+++ b/emulators/VisualBoyAdvance/files/libpng-1.4.patch
</span><span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -0,0 +1,14 @@
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+Fix for compatibility with libpng 1.4+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+https://github.com/x3ro/VisualBoyAdvance/pull/1/commits/1292c3b70337cccddf52e8d5de23bd785687d92a
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+--- src/Util.cpp.orig 2004-05-20 12:42:37.000000000 -0500
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++++ src/Util.cpp 2018-10-07 22:30:32.000000000 -0500
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+@@ -79,7 +79,7 @@
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ return false;
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ }
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+- if(setjmp(png_ptr->jmpbuf)) {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++ if(setjmp(png_jmpbuf(png_ptr))) {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ png_destroy_write_struct(&png_ptr,NULL);
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ fclose(fp);
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ return false;
</span></pre><pre style='margin:0'>
</pre>