<pre style='margin:0'>
Chih-Hsuan Yen (yan12125) pushed a commit to branch master
in repository macports-ports.
</pre>
<p><a href="https://github.com/macports/macports-ports/commit/98445d69fc13be9c968abe4c597de8324b0ceee6">https://github.com/macports/macports-ports/commit/98445d69fc13be9c968abe4c597de8324b0ceee6</a></p>
<pre style="white-space: pre; background: #F8F8F8">The following commit(s) were added to refs/heads/master by this push:
<span style='display:block; white-space:pre;color:#404040;'> new 98445d6 quazip: fix building on 10.8
</span>98445d6 is described below
<span style='display:block; white-space:pre;color:#808000;'>commit 98445d69fc13be9c968abe4c597de8324b0ceee6
</span>Author: Chih-Hsuan Yen <yan12125@macports.org>
AuthorDate: Fri Nov 30 11:13:14 2018 +0800
<span style='display:block; white-space:pre;color:#404040;'> quazip: fix building on 10.8
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> That's a very long story...
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> 1. On 10.8, Qt 5.7 is used, and in this version cxx_decltype feature is
</span><span style='display:block; white-space:pre;color:#404040;'> requested [1]
</span><span style='display:block; white-space:pre;color:#404040;'> 2. Compiler features detection requires CMAKE_*_STANDARD_COMPILE_OPTION
</span><span style='display:block; white-space:pre;color:#404040;'> (Modules/Compiler/CMakeCommonCompilerMacros.cmake)
</span><span style='display:block; white-space:pre;color:#404040;'> 3. CMAKE_*_STANDARD_COMPILE_OPTION are defined in
</span><span style='display:block; white-space:pre;color:#404040;'> Modules/Compiler/Clang-CXX.cmake. However, those definitions are
</span><span style='display:block; white-space:pre;color:#404040;'> skipped if the system is Apple and CMP0025 is not NEW
</span><span style='display:block; white-space:pre;color:#404040;'> 4. We have -DCMAKE_POLICY_DEFAULT_CMP0025=NEW. Why doesn't it work?
</span><span style='display:block; white-space:pre;color:#404040;'> That's because CMAKE_POLICY_DEFAULT_* variables are handled in the
</span><span style='display:block; white-space:pre;color:#404040;'> cmake_minimum_required() command [2], while compiler feature
</span><span style='display:block; white-space:pre;color:#404040;'> detection occurs in the project() command.
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> Now the conclusion - cmake_minimum_required() should be before project()
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> Ref: https://trac.macports.org/ticket/57700
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> [1] https://bugreports.qt.io/browse/QTBUG-57886
</span><span style='display:block; white-space:pre;color:#404040;'> [2] https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html
</span>---
archivers/quazip/Portfile | 2 ++
archivers/quazip/files/trac-57700.patch | 11 +++++++++++
2 files changed, 13 insertions(+)
<span style='display:block; white-space:pre;color:#808080;'>diff --git a/archivers/quazip/Portfile b/archivers/quazip/Portfile
</span><span style='display:block; white-space:pre;color:#808080;'>index cd17923..c9fff42 100644
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>--- a/archivers/quazip/Portfile
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>+++ b/archivers/quazip/Portfile
</span><span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -26,3 +26,5 @@ homepage https://stachenov.github.io/quazip/
</span> checksums rmd160 1d612f64c94c83ba291998d0ae6b9acae816d830 \
sha256 4118a830a375a81211956611cc34b1b5b4ddc108c126287b91b40c2493046b70 \
size 149029
<span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+patchfiles-append trac-57700.patch
</span><span style='display:block; white-space:pre;color:#808080;'>diff --git a/archivers/quazip/files/trac-57700.patch b/archivers/quazip/files/trac-57700.patch
</span>new file mode 100644
<span style='display:block; white-space:pre;color:#808080;'>index 0000000..aa31c16
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>--- /dev/null
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>+++ b/archivers/quazip/files/trac-57700.patch
</span><span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -0,0 +1,11 @@
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+diff --git CMakeLists.txt CMakeLists.txt
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+index 3d2fb55..539caa4 100644
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+--- CMakeLists.txt
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++++ CMakeLists.txt
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+@@ -1,5 +1,5 @@
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+-project(QuaZip)
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ cmake_minimum_required(VERSION 2.6)
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++project(QuaZip)
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ # CMP0042: Explicitly acknowledge MACOSX_RPATH
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ # (introduced in CMake 2.8.12, enabled by default in CMake 3.0,
</span></pre><pre style='margin:0'>
</pre>