<pre style='margin:0'>
Zero King (l2dy) pushed a commit to branch master
in repository mpbot-github.
</pre>
<p><a href="https://github.com/macports/mpbot-github/commit/6f8aa8f2539bea6d6fcaa7659c0bb8bf4495d3f6">https://github.com/macports/mpbot-github/commit/6f8aa8f2539bea6d6fcaa7659c0bb8bf4495d3f6</a></p>
<pre style="white-space: pre; background: #F8F8F8">The following commit(s) were added to refs/heads/master by this push:
<span style='display:block; white-space:pre;color:#404040;'> new 6f8aa8f improve test for 'update' label
</span>6f8aa8f is described below
<span style='display:block; white-space:pre;color:#808000;'>commit 6f8aa8f2539bea6d6fcaa7659c0bb8bf4495d3f6
</span>Author: Helmut K. C. Tessarek <tessarek@evermeet.cx>
AuthorDate: Tue Apr 23 17:22:36 2019 -0400
<span style='display:block; white-space:pre;color:#404040;'> improve test for 'update' label
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> The test for an update is too specific. It misses several cases:
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> update PORT to NNN
</span><span style='display:block; white-space:pre;color:#404040;'> PORT: update MAINPORT to NNN, SUBPORT to NNN
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> Some people might want to use the type `- [x] update` in the body.
</span>---
pr/webhook/pull_request.go | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
<span style='display:block; white-space:pre;color:#808080;'>diff --git a/pr/webhook/pull_request.go b/pr/webhook/pull_request.go
</span><span style='display:block; white-space:pre;color:#808080;'>index c3e5cc9..55a7b83 100644
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>--- a/pr/webhook/pull_request.go
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>+++ b/pr/webhook/pull_request.go
</span><span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -174,13 +174,13 @@ func (receiver *Receiver) processPullRequest(event *github.PullRequestEvent) {
</span> if isSubmission {
typeLabels = appendIfUnique(typeLabels, "type: submission")
}
<span style='display:block; white-space:pre;background:#ffe0e0;'>- if strings.Contains(strings.ToLower(*event.PullRequest.Title), ": update to") {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if strings.Contains(strings.ToLower(*event.PullRequest.Title), ": update") || strings.HasPrefix(strings.ToLower(*event.PullRequest.Title), "update") {
</span> typeLabels = appendIfUnique(typeLabels, "type: update")
}
if cveRegexp.FindString(*event.PullRequest.Title) != "" || cveRegexp.FindString(*event.PullRequest.Body) != "" {
typeLabels = appendIfUnique(typeLabels, "type: security fix")
}
<span style='display:block; white-space:pre;background:#ffe0e0;'>- typesFromBody := []string{"bugfix", "enhancement", "security fix"}
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ typesFromBody := []string{"bugfix", "enhancement", "security fix", "update"}
</span> for _, t := range typesFromBody {
if strings.Contains(*event.PullRequest.Body, "[x] "+t) {
typeLabels = appendIfUnique(typeLabels, "type: "+t)
</pre><pre style='margin:0'>
</pre>