<pre style='margin:0'>
Ryan Schmidt (ryandesign) pushed a commit to branch master
in repository macports-ports.
</pre>
<p><a href="https://github.com/macports/macports-ports/commit/b1505aa16a54615dba9dd67535fb90d15fb1b2f7">https://github.com/macports/macports-ports/commit/b1505aa16a54615dba9dd67535fb90d15fb1b2f7</a></p>
<pre style="white-space: pre; background: #F8F8F8">The following commit(s) were added to refs/heads/master by this push:
<span style='display:block; white-space:pre;color:#404040;'> new b1505aa nodejs12: Don't use -latomic on macOS
</span>b1505aa is described below
<span style='display:block; white-space:pre;color:#808000;'>commit b1505aa16a54615dba9dd67535fb90d15fb1b2f7
</span>Author: Ryan Schmidt <ryandesign@macports.org>
AuthorDate: Wed Oct 23 15:48:52 2019 -0500
<span style='display:block; white-space:pre;color:#404040;'> nodejs12: Don't use -latomic on macOS
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> Fixes build with MacPorts clang. Due to another bug, builds with Xcode clang
</span><span style='display:block; white-space:pre;color:#404040;'> were misidentified as "not clang" and therefore already didn't add the -latomic
</span><span style='display:block; white-space:pre;color:#404040;'> flag, allowing the build to succeed.
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> Closes: https://trac.macports.org/ticket/58695
</span>---
devel/nodejs12/Portfile | 1 +
devel/nodejs12/files/patch-node.gyp.diff | 19 +++++++++++++++++++
2 files changed, 20 insertions(+)
<span style='display:block; white-space:pre;color:#808080;'>diff --git a/devel/nodejs12/Portfile b/devel/nodejs12/Portfile
</span><span style='display:block; white-space:pre;color:#808080;'>index 059dfde..06401d3 100644
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>--- a/devel/nodejs12/Portfile
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>+++ b/devel/nodejs12/Portfile
</span><span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -54,6 +54,7 @@ proc rec_glob {basedir pattern} {
</span> configure.python ${prefix}/bin/python2.7
patchfiles patch-common.gypi.diff
<span style='display:block; white-space:pre;background:#e0ffe0;'>+patchfiles-append patch-node.gyp.diff
</span>
post-patch {
foreach f [concat ${worksrcpath}/configure \
<span style='display:block; white-space:pre;color:#808080;'>diff --git a/devel/nodejs12/files/patch-node.gyp.diff b/devel/nodejs12/files/patch-node.gyp.diff
</span>new file mode 100644
<span style='display:block; white-space:pre;color:#808080;'>index 0000000..f747fe6
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>--- /dev/null
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>+++ b/devel/nodejs12/files/patch-node.gyp.diff
</span><span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -0,0 +1,19 @@
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+Don't use -latomic on macOS. Clang on macOS doesn't use libatomic.
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+https://github.com/nodejs/node/issues/30093
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+This bug caused the build to fail when using MacPorts clang. Due to a second
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+bug, in which node's build system misidentifies clang from Xcode 7 and later
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+as "not clang", it didn't add -latomic for Xcode clang and thus the build
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+succeeded.
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+--- node.gyp.orig 2019-10-23 15:09:52.000000000 -0500
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++++ node.gyp 2019-10-23 15:27:25.000000000 -0500
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+@@ -290,7 +290,7 @@
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ '-Wl,-bnoerrmsg',
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ ],
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ }],
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+- ['(OS=="linux" or OS=="mac") and llvm_version!=0', {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++ ['OS=="linux" and llvm_version!=0', {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ 'libraries': ['-latomic'],
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ }],
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ ],
</span></pre><pre style='margin:0'>
</pre>