<pre style='margin:0'>
Ryan Schmidt (ryandesign) pushed a commit to branch master
in repository macports-base.
</pre>
<p><a href="https://github.com/macports/macports-base/commit/ab5797a69bf146857f01946a0dfdd5dc37a791c9">https://github.com/macports/macports-base/commit/ab5797a69bf146857f01946a0dfdd5dc37a791c9</a></p>
<pre style="white-space: pre; background: #F8F8F8">The following commit(s) were added to refs/heads/master by this push:
<span style='display:block; white-space:pre;color:#404040;'> new ab5797a6 Move trailing newline lint check out of nitpick
</span>ab5797a6 is described below
<span style='display:block; white-space:pre;color:#808000;'>commit ab5797a69bf146857f01946a0dfdd5dc37a791c9
</span>Author: Ryan Schmidt <ryandesign@macports.org>
AuthorDate: Mon Jul 20 20:43:30 2020 -0500
<span style='display:block; white-space:pre;color:#404040;'> Move trailing newline lint check out of nitpick
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> This isn't a nitpick. Portfiles are supposed to be text files and text
</span><span style='display:block; white-space:pre;color:#404040;'> files according to POSIX must end with the newline character.
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> See: https://trac.macports.org/ticket/56040
</span>---
src/port1.0/portlint.tcl | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
<span style='display:block; white-space:pre;color:#808080;'>diff --git a/src/port1.0/portlint.tcl b/src/port1.0/portlint.tcl
</span><span style='display:block; white-space:pre;color:#808080;'>index c068eebd..9460b7e5 100644
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>--- a/src/port1.0/portlint.tcl
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>+++ b/src/port1.0/portlint.tcl
</span><span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -293,13 +293,11 @@ proc portlint::lint_main {args} {
</span> while {1} {
set line [gets $f]
if {[eof $f]} {
<span style='display:block; white-space:pre;background:#ffe0e0;'>- if {$nitpick} {
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- seek $f -1 end
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- set last [read $f 1]
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- if {"\n" ne $last} {
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- ui_warn "Line $lineno has missing newline (at end of file)"
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- incr warnings
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- }
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ seek $f -1 end
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ set last [read $f 1]
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if {"\n" ne $last} {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ ui_warn "Line $lineno has missing newline (at end of file)"
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ incr warnings
</span> }
close $f
break
</pre><pre style='margin:0'>
</pre>