<pre style='margin:0'>
Joshua Root (jmroot) pushed a commit to branch master
in repository mpbb.

</pre>
<p><a href="https://github.com/macports/mpbb/commit/28eab47c0adb5ac8625cc8a515bbde983e7ded23">https://github.com/macports/mpbb/commit/28eab47c0adb5ac8625cc8a515bbde983e7ded23</a></p>
<pre style="white-space: pre; background: #F8F8F8">The following commit(s) were added to refs/heads/master by this push:
<span style='display:block; white-space:pre;color:#404040;'>     new 28eab47  mpbb: only warn about dependency cycles
</span>28eab47 is described below

<span style='display:block; white-space:pre;color:#808000;'>commit 28eab47c0adb5ac8625cc8a515bbde983e7ded23
</span>Author: Joshua Root <jmr@macports.org>
AuthorDate: Wed Jan 6 01:11:14 2021 +1100

<span style='display:block; white-space:pre;color:#404040;'>    mpbb: only warn about dependency cycles
</span><span style='display:block; white-space:pre;color:#404040;'>    
</span><span style='display:block; white-space:pre;color:#404040;'>    Some cycles involving depends_test exist and affect a large number of
</span><span style='display:block; white-space:pre;color:#404040;'>    ports on 10.6, e.g. libffi. This isn't a problem yet, but will be if we
</span><span style='display:block; white-space:pre;color:#404040;'>    start running tests. Letting affected ports through for now and letting
</span><span style='display:block; white-space:pre;color:#404040;'>    them possibly fail later, since so many would be unnecessarily excluded
</span><span style='display:block; white-space:pre;color:#404040;'>    otherwise.
</span>---
 tools/sort-with-subports.tcl | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

<span style='display:block; white-space:pre;color:#808080;'>diff --git a/tools/sort-with-subports.tcl b/tools/sort-with-subports.tcl
</span><span style='display:block; white-space:pre;color:#808080;'>index 3fa2454..7329aa3 100755
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>--- a/tools/sort-with-subports.tcl
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>+++ b/tools/sort-with-subports.tcl
</span><span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -84,13 +84,18 @@ proc check_failing_deps {portname} {
</span>                     set ::outputports($portname) 0
                 } elseif {$status == 3} {
                     if {[info exists ::requestedports($portname)]} {
<span style='display:block; white-space:pre;background:#ffe0e0;'>-                        puts stderr "Excluding $::canonicalnames($portname) because of a cyclic dependency involving '$portdep'"
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+                        puts stderr "Warning: $::canonicalnames($portname) appears to have a cyclic dependency involving '$portdep'"
</span>                     }
<span style='display:block; white-space:pre;background:#ffe0e0;'>-                    set ::outputports($portname) 0
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+                    # Some cycles involving depends_test exist, which don't cause
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+                    # problems yet only because we don't run tests.
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+                    #set ::outputports($portname) 0
</span>                 }
             }
<span style='display:block; white-space:pre;background:#ffe0e0;'>-            set ::failingports($portname) [list $status $failed_dep]
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-            return $::failingports($portname)
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+            # keep processing other deps for now if there was a dep cycle
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+            if {$status != 3} {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+                set ::failingports($portname) [list $status $failed_dep]
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+                return $::failingports($portname)
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+            }
</span>         }
     }
     set ::failingports($portname) [list 0 ""]
</pre><pre style='margin:0'>

</pre>