<pre style='margin:0'>
Ken (kencu) pushed a commit to branch master
in repository macports-ports.

</pre>
<p><a href="https://github.com/macports/macports-ports/commit/0e7c11c8e934af9075ad52ecbca35af67f7d3e98">https://github.com/macports/macports-ports/commit/0e7c11c8e934af9075ad52ecbca35af67f7d3e98</a></p>
<pre style="white-space: pre; background: #F8F8F8">The following commit(s) were added to refs/heads/master by this push:
<span style='display:block; white-space:pre;color:#404040;'>     new 0e7c11c8e93 icu: clarify merger_must_run_binaries comments
</span>0e7c11c8e93 is described below

<span style='display:block; white-space:pre;color:#808000;'>commit 0e7c11c8e934af9075ad52ecbca35af67f7d3e98
</span>Author: Ken Cunningham <kencu@macports.org>
AuthorDate: Thu Apr 8 22:06:49 2021 -0700

<span style='display:block; white-space:pre;color:#404040;'>    icu: clarify merger_must_run_binaries comments
</span><span style='display:block; white-space:pre;color:#404040;'>    
</span><span style='display:block; white-space:pre;color:#404040;'>    this will explain why we have to change this if we want
</span><span style='display:block; white-space:pre;color:#404040;'>    to support building universal on an Intel Mac
</span>---
 devel/icu/Portfile | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

<span style='display:block; white-space:pre;color:#808080;'>diff --git a/devel/icu/Portfile b/devel/icu/Portfile
</span><span style='display:block; white-space:pre;color:#808080;'>index 32b0f65d8f5..0bc89e0ae97 100644
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>--- a/devel/icu/Portfile
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>+++ b/devel/icu/Portfile
</span><span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -73,10 +73,10 @@ if {${subport} eq ${name} || ${subport} eq "${name}-lx"} {
</span> 
     configure.universal_args-delete --disable-dependency-tracking
 
<span style='display:block; white-space:pre;background:#ffe0e0;'>-    # ICU detects cross compiling by trying to run binaries.
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-    # r73849 and #29904 indicate that cross compiling is a problem.
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-    # Of the solutions tried (r79660, r73865, and r73849), simply disallowing cross compiling is by far the simplest.
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-    # Note that #29904 should not show up again because universal now better recognizes 32/64-bit cross compiling (r79658)
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+    # ICU needs to run binaries when building, to generate its data.
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+    # Simply disallowing cross compiling is the simplest solution, however
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+    # that means that an x86_64/arm64 universal version can never be built on an Intel Mac.
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+    # ancient refs: #29904, ancient solutions tried (r79660, r73865, and r73849)
</span>     merger_must_run_binaries yes
 
     build.type      gnu
</pre><pre style='margin:0'>

</pre>