<pre style='margin:0'>
Christopher Nielsen (mascguy) pushed a commit to branch master
in repository macports-ports.
</pre>
<p><a href="https://github.com/macports/macports-ports/commit/5f015a4f5c97653aa70075ec78c8fe4afd1d5435">https://github.com/macports/macports-ports/commit/5f015a4f5c97653aa70075ec78c8fe4afd1d5435</a></p>
<pre style="white-space: pre; background: #F8F8F8"><span style='display:block; white-space:pre;color:#808000;'>commit 5f015a4f5c97653aa70075ec78c8fe4afd1d5435
</span>Author: Christopher Nielsen <mascguy@github.com>
AuthorDate: Fri May 7 16:33:20 2021 -0400
<span style='display:block; white-space:pre;color:#404040;'> opencv3/opencv4: add comment emphasizing need to test contrib variant
</span>---
graphics/opencv3/Portfile | 17 +++++++++++++++++
graphics/opencv4/Portfile | 17 +++++++++++++++++
2 files changed, 34 insertions(+)
<span style='display:block; white-space:pre;color:#808080;'>diff --git a/graphics/opencv3/Portfile b/graphics/opencv3/Portfile
</span><span style='display:block; white-space:pre;color:#808080;'>index e81a6b31e5d..5d71e795b16 100644
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>--- a/graphics/opencv3/Portfile
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>+++ b/graphics/opencv3/Portfile
</span><span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -5,6 +5,23 @@ PortGroup cmake 1.1
</span> PortGroup compiler_blacklist_versions 1.0
PortGroup legacysupport 1.0
<span style='display:block; white-space:pre;background:#e0ffe0;'>+#==============================================================================
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+# IMPORTANT NOTE
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+#
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+# Before updating to a new version from upstream, please test building with
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+# +contrib, in addition to the default. Reason being, the extra functionality
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+# is used by many, including our own MacPorts members. Enough so that we may
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+# want to enable +contrib by default at some point.
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+#
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+# Also note that upstream has occassionally broken the Contrib build, so it's
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+# not a given that it will compile successfully.
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+#
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+# Net-Net: If upstream breaks Contrib for a certain release, please don't
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+# update to it. And submit a ticket for the issue, if none exists.
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+#
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+# Thanks!
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+#==============================================================================
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span> name opencv3
version 3.4.14
revision 0
<span style='display:block; white-space:pre;color:#808080;'>diff --git a/graphics/opencv4/Portfile b/graphics/opencv4/Portfile
</span><span style='display:block; white-space:pre;color:#808080;'>index e8f3f3d6974..ad46b2c3b75 100644
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>--- a/graphics/opencv4/Portfile
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>+++ b/graphics/opencv4/Portfile
</span><span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -5,6 +5,23 @@ PortGroup cmake 1.1
</span> PortGroup compiler_blacklist_versions 1.0
PortGroup github 1.0
<span style='display:block; white-space:pre;background:#e0ffe0;'>+#==============================================================================
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+# IMPORTANT NOTE
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+#
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+# Before updating to a new version from upstream, please test building with
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+# +contrib, in addition to the default. Reason being, the extra functionality
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+# is used by many, including our own MacPorts members. Enough so that we may
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+# want to enable +contrib by default at some point.
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+#
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+# Also note that upstream has occassionally broken the Contrib build, so it's
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+# not a given that it will compile successfully.
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+#
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+# Net-Net: If upstream breaks Contrib for a certain release, please don't
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+# update to it. And submit a ticket for the issue, if none exists.
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+#
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+# Thanks!
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+#==============================================================================
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span> github.setup opencv opencv 4.5.2
name opencv4
revision 1
</pre><pre style='margin:0'>
</pre>