<pre style='margin:0'>
Joshua Root (jmroot) pushed a commit to branch master
in repository macports-base.
</pre>
<p><a href="https://github.com/macports/macports-base/commit/087ce29788c7ada01324163c2248ff05e49dd8f4">https://github.com/macports/macports-base/commit/087ce29788c7ada01324163c2248ff05e49dd8f4</a></p>
<pre style="white-space: pre; background: #F8F8F8">The following commit(s) were added to refs/heads/master by this push:
<span style='display:block; white-space:pre;color:#404040;'> new 087ce297 Fix values returned by portconfigure::get_min_gcc
</span>087ce297 is described below
<span style='display:block; white-space:pre;color:#808000;'>commit 087ce29788c7ada01324163c2248ff05e49dd8f4
</span>Author: Joshua Root <jmr@macports.org>
AuthorDate: Fri Jul 23 08:17:45 2021 +1000
<span style='display:block; white-space:pre;color:#404040;'> Fix values returned by portconfigure::get_min_gcc
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> These need to match the final segment of a configure.compiler value.
</span><span style='display:block; white-space:pre;color:#404040;'> For example, macports-gcc-4.8 yields a version of 4.8, and
</span><span style='display:block; white-space:pre;color:#404040;'> macports-gcc-7 yields 7. So 8.1 would not match macports-gcc-8 even
</span><span style='display:block; white-space:pre;color:#404040;'> though the gcc8 port in fact provides a newer version than that. Also,
</span><span style='display:block; white-space:pre;color:#404040;'> vercmp treats n.0 as greater than n, not equal.
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> Fixes: https://trac.macports.org/ticket/63281
</span>---
src/port1.0/portconfigure.tcl | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
<span style='display:block; white-space:pre;color:#808080;'>diff --git a/src/port1.0/portconfigure.tcl b/src/port1.0/portconfigure.tcl
</span><span style='display:block; white-space:pre;color:#808080;'>index 1d834c95..8d034b55 100644
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>--- a/src/port1.0/portconfigure.tcl
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>+++ b/src/port1.0/portconfigure.tcl
</span><span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -1003,21 +1003,21 @@ proc portconfigure::get_min_gcc {} {
</span>
set min_value 1.0
if {${compiler.c_standard} >= 2017} {
<span style='display:block; white-space:pre;background:#ffe0e0;'>- set min_value [max_version $min_value 8.0]
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ set min_value [max_version $min_value 8]
</span> } elseif {${compiler.c_standard} >= 2011} {
set min_value [max_version $min_value 4.3]
} elseif {${compiler.c_standard} >= 1999} {
set min_value [max_version $min_value 4.0]
}
if {${compiler.cxx_standard} >= 2017} {
<span style='display:block; white-space:pre;background:#ffe0e0;'>- set min_value [max_version $min_value 7.0]
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ set min_value [max_version $min_value 7]
</span> } elseif {${compiler.cxx_standard} >= 2014} {
<span style='display:block; white-space:pre;background:#ffe0e0;'>- set min_value [max_version $min_value 5.0]
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ set min_value [max_version $min_value 5]
</span> } elseif {${compiler.cxx_standard} >= 2011} {
<span style='display:block; white-space:pre;background:#ffe0e0;'>- set min_value [max_version $min_value 4.8.1]
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ set min_value [max_version $min_value 4.8]
</span> }
if {[vercmp ${compiler.openmp_version} 4.5] >= 0} {
<span style='display:block; white-space:pre;background:#ffe0e0;'>- set min_value [max_version $min_value 8.1]
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ set min_value [max_version $min_value 8]
</span> } elseif {[vercmp ${compiler.openmp_version} 4.0] >= 0} {
set min_value [max_version $min_value 4.9]
} elseif {[vercmp ${compiler.openmp_version} 3.1] >= 0} {
<span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -1035,7 +1035,7 @@ proc portconfigure::get_min_gcc {} {
</span> ([option compiler.limit_flags] || [option compiler.support_environment_sdkroot]) &&
[option configure.sdkroot] ne ""
} {
<span style='display:block; white-space:pre;background:#ffe0e0;'>- set min_value [max_version $min_value 7.0]
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ set min_value [max_version $min_value 7]
</span> }
return ${min_value}
}
<span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -1044,7 +1044,7 @@ proc portconfigure::get_min_gfortran {} {
</span> global compiler.openmp_version compiler.thread_local_storage
set min_value 1.0
if {[vercmp ${compiler.openmp_version} 4.5] >= 0} {
<span style='display:block; white-space:pre;background:#ffe0e0;'>- set min_value [max_version $min_value 8.1]
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ set min_value [max_version $min_value 8]
</span> } elseif {[vercmp ${compiler.openmp_version} 4.0] >= 0} {
set min_value [max_version $min_value 4.9]
} elseif {[vercmp ${compiler.openmp_version} 3.1] >= 0} {
<span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -1060,7 +1060,7 @@ proc portconfigure::get_min_gfortran {} {
</span> ([option compiler.limit_flags] || [option compiler.support_environment_sdkroot]) &&
[option configure.sdkroot] ne ""
} {
<span style='display:block; white-space:pre;background:#ffe0e0;'>- set min_value [max_version $min_value 7.0]
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ set min_value [max_version $min_value 7]
</span> }
return ${min_value}
}
</pre><pre style='margin:0'>
</pre>