<pre style='margin:0'>
Ryan Schmidt (ryandesign) pushed a commit to branch master
in repository macports-ports.
</pre>
<p><a href="https://github.com/macports/macports-ports/commit/1ab27d5b3cff6e9ba7fe8c9c3fe73790dc788fad">https://github.com/macports/macports-ports/commit/1ab27d5b3cff6e9ba7fe8c9c3fe73790dc788fad</a></p>
<pre style="white-space: pre; background: #F8F8F8">The following commit(s) were added to refs/heads/master by this push:
<span style='display:block; white-space:pre;color:#404040;'> new 1ab27d5b3cf dfu-programmer: Fix implicit declaration of funcs
</span>1ab27d5b3cf is described below
<span style='display:block; white-space:pre;color:#808000;'>commit 1ab27d5b3cff6e9ba7fe8c9c3fe73790dc788fad
</span>Author: Ryan Schmidt <ryandesign@macports.org>
AuthorDate: Mon Aug 30 06:29:48 2021 -0500
<span style='display:block; white-space:pre;color:#404040;'> dfu-programmer: Fix implicit declaration of funcs
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> Closes: https://trac.macports.org/ticket/61802
</span>---
cross/dfu-programmer/Portfile | 15 +++++--
cross/dfu-programmer/files/implicit.patch | 70 +++++++++++++++++++++++++++++++
2 files changed, 82 insertions(+), 3 deletions(-)
<span style='display:block; white-space:pre;color:#808080;'>diff --git a/cross/dfu-programmer/Portfile b/cross/dfu-programmer/Portfile
</span><span style='display:block; white-space:pre;color:#808080;'>index 3c3319a51ca..78cf80c75a0 100644
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>--- a/cross/dfu-programmer/Portfile
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>+++ b/cross/dfu-programmer/Portfile
</span><span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -4,18 +4,21 @@ PortSystem 1.0
</span>
name dfu-programmer
version 0.7.2
<span style='display:block; white-space:pre;background:#e0ffe0;'>+revision 0
</span> categories cross devel
license GPL-2
maintainers nomaintainer
<span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span> description dfu-programmer is a Device Firmware Update based USB programmer for Atmel chips with a USB bootloader.
<span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span> long_description dfu-programmer is an implementation of the Device Firmware Upgrade class \
USB driver that enables firmware upgrades for various USB enabled (with the \
correct bootloader) Atmel chips. This program was created because the \
Atmel "FLIP" program for flashing devices does not support flashing via USB \
on Linux, and because standard DFU loaders do not work for Atmel's chips.
<span style='display:block; white-space:pre;background:#ffe0e0;'>-homepage http://dfu-programmer.sourceforge.net/
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-platforms darwin
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-master_sites sourceforge
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+homepage https://dfu-programmer.github.io
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+master_sites sourceforge:project/dfu-programmer/dfu-programmer/${version}
</span>
checksums rmd160 2f124739c294e373c83fb108b03c3fd8913e4351 \
sha256 1db4d36b1aedab2adc976e8faa5495df3cf82dc4bf883633dc6ba71f7c4af995 \
<span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -26,3 +29,9 @@ depends_build-append \
</span>
depends_lib-append \
path:lib/libusb.dylib:libusb
<span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+patchfiles implicit.patch
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+# We are patching configure.ac
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+use_autoreconf yes
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+autoreconf.args -fvi
</span><span style='display:block; white-space:pre;color:#808080;'>diff --git a/cross/dfu-programmer/files/implicit.patch b/cross/dfu-programmer/files/implicit.patch
</span>new file mode 100644
<span style='display:block; white-space:pre;color:#808080;'>index 00000000000..6370ffd7c77
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>--- /dev/null
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>+++ b/cross/dfu-programmer/files/implicit.patch
</span><span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -0,0 +1,70 @@
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+Fix:
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+error: implicitly declaring library function 'memcmp' with type 'int (const void *, const void *, unsigned long)' [-Werror,-Wimplicit-function-declaration]
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+error: implicitly declaring library function 'strcpy' with type 'char *(char *, const char *)' [-Werror,-Wimplicit-function-declaration]
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+These problems in the configure script seem to stem from misuse of autoconf
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+features. Something about the way the checks for libusb are written prevents
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+autoconf from being able to determine later that the headers and functions
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+exist so move the checks for headers and functions before the libusb check.
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+https://github.com/dfu-programmer/dfu-programmer/issues/61
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+Fix:
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+error: implicitly declaring library function 'malloc' with type 'void *(unsigned long)' [-Werror,-Wimplicit-function-declaration]
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+Upstream has already fixed this problem by moving the code that uses malloc
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+from atmel.c to intel_hex.c which already includes <stdlib.h>.
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+https://github.com/dfu-programmer/dfu-programmer/commit/26d96f2195312bdb1dbe5af673acea900eda4318
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+--- configure.ac.orig
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++++ configure.ac
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+@@ -13,6 +13,17 @@ AM_MAINTAINER_MODE
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ # Checks for programs.
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ AC_PROG_CC
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++# Checks for header files.
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++AC_HEADER_STDC
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++# Checks for typedefs, structures, and compiler characteristics.
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++AC_C_CONST
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++AC_TYPE_SIZE_T
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++# Checks for library functions.
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++AC_FUNC_MALLOC
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++AC_FUNC_MEMCMP
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ # Checks for libusb - from sane-backends configuration
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ dnl Enable libusb-1.0, if available
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+@@ -64,17 +75,6 @@ if test "$HAVE_USB" = "yes"; then
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ fi
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+-# Checks for header files.
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+-AC_HEADER_STDC
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+-
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+-# Checks for typedefs, structures, and compiler characteristics.
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+-AC_C_CONST
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+-AC_TYPE_SIZE_T
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+-
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+-# Checks for library functions.
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+-AC_FUNC_MALLOC
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+-AC_FUNC_MEMCMP
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+-#AC_CHECK_FUNC([memset], :, [AC_CHECK_LIB([libc], [libc])])
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ AC_CONFIG_FILES(fedora/dfu-programmer.spec Makefile docs/Makefile src/Makefile)
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ AC_OUTPUT
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+--- src/atmel.c.orig 2014-08-01 05:54:25.000000000 -0500
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++++ src/atmel.c 2020-12-10 21:36:44.000000000 -0600
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+@@ -21,6 +21,7 @@
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ #include <stdio.h>
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ #include <stdarg.h>
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ #include <stdint.h>
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++#include <stdlib.h>
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ #include <string.h>
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ #include <stddef.h>
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ #include <errno.h>
</span></pre><pre style='margin:0'>
</pre>