<pre style='margin:0'>
Joshua Root (jmroot) pushed a commit to branch master
in repository macports-ports.
</pre>
<p><a href="https://github.com/macports/macports-ports/commit/72f06e4f7e5a6c01f66d3f9f0859643fd163393b">https://github.com/macports/macports-ports/commit/72f06e4f7e5a6c01f66d3f9f0859643fd163393b</a></p>
<pre style="white-space: pre; background: #F8F8F8"><span style='display:block; white-space:pre;color:#808000;'>commit 72f06e4f7e5a6c01f66d3f9f0859643fd163393b
</span>Author: Joshua Root <jmr@macports.org>
AuthorDate: Sun Sep 18 04:07:24 2022 +1000
<span style='display:block; white-space:pre;color:#404040;'> Revert "xcodeversions PG: Refactor to allow known_fail to be set when appropriate"
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> This reverts commit 9e07f01ff0f735e663f01fa27155634372e59d0e.
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> See GitHub comment on that commit.
</span>---
_resources/port1.0/group/xcodeversion-1.0.tcl | 34 +++++++--------------------
1 file changed, 9 insertions(+), 25 deletions(-)
<span style='display:block; white-space:pre;color:#808080;'>diff --git a/_resources/port1.0/group/xcodeversion-1.0.tcl b/_resources/port1.0/group/xcodeversion-1.0.tcl
</span><span style='display:block; white-space:pre;color:#808080;'>index 86ae83337e2..8529f284d01 100644
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>--- a/_resources/port1.0/group/xcodeversion-1.0.tcl
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>+++ b/_resources/port1.0/group/xcodeversion-1.0.tcl
</span><span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -14,35 +14,20 @@
</span> options minimum_xcodeversions
default minimum_xcodeversions {}
<span style='display:block; white-space:pre;background:#ffe0e0;'>-proc xcodeversions_get_minimum { } {
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- global minimum_xcodeversions os.major
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- foreach {darwin_major minimum_xcodeversion} [join ${minimum_xcodeversions}] {
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- if {${darwin_major} == ${os.major}} {
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- return ${minimum_xcodeversion}
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- }
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- }
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- return "none"
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-}
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-proc xcodeversions_run_check { } {
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- global os.major xcodeversion
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- platform macosx {
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- set minimum_xcodeversion [xcodeversions_get_minimum]
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- if { $minimum_xcodeversion ne "none" } {
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- if {![info exists xcodeversion] || $xcodeversion eq "none"} {
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- pre-extract {
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- ui_error "Could not determine your Xcode version (from '/usr/bin/xcodebuild -version')."
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+platform macosx {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ pre-extract {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ foreach {darwin_major minimum_xcodeversion} [join ${minimum_xcodeversions}] {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if {${darwin_major} == ${os.major}} {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if {![info exists xcodeversion] || $xcodeversion eq "none"} {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ ui_error "Couldn't determine your Xcode version (from '/usr/bin/xcodebuild -version')."
</span> ui_error ""
<span style='display:block; white-space:pre;background:#ffe0e0;'>- ui_error "On macOS ${macosx_version}, ${name} @${version} requires Xcode [xcodeversions_get_minimum] or later but you have none installed."
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ ui_error "On macOS ${macosx_version}, ${name} @${version} requires Xcode ${minimum_xcodeversion} or later but you have none installed."
</span> ui_error "See https://guide.macports.org/chunked/installing.xcode.html for download links."
ui_error ""
return -code error "unable to find Xcode"
}
<span style='display:block; white-space:pre;background:#ffe0e0;'>- }
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- if {[vercmp ${xcodeversion} ${minimum_xcodeversion}] < 0} {
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- known_fail yes
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- pre-extract {
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- ui_error "On macOS ${macosx_version}, ${name} @${version} requires Xcode [xcodeversions_get_minimum] or later but you have Xcode ${xcodeversion}."
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if {[vercmp ${xcodeversion} ${minimum_xcodeversion}] < 0} {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ ui_error "On macOS ${macosx_version}, ${name} @${version} requires Xcode ${minimum_xcodeversion} or later but you have Xcode ${xcodeversion}."
</span> ui_error "See https://guide.macports.org/chunked/installing.xcode.html for download links."
return -code error "incompatible Xcode version"
}
<span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -50,4 +35,3 @@ proc xcodeversions_run_check { } {
</span> }
}
}
<span style='display:block; white-space:pre;background:#ffe0e0;'>-port::register_callback xcodeversions_run_check
</span></pre><pre style='margin:0'>
</pre>