<pre style='margin:0'>
Joshua Root (jmroot) pushed a commit to branch master
in repository macports-base.
</pre>
<p><a href="https://github.com/macports/macports-base/commit/5988c006492023be222bb4545835080ce04a8508">https://github.com/macports/macports-base/commit/5988c006492023be222bb4545835080ce04a8508</a></p>
<pre style="white-space: pre; background: #F8F8F8">The following commit(s) were added to refs/heads/master by this push:
<span style='display:block; white-space:pre;color:#404040;'> new 5988c0064 macports.tcl: Fix regression in 5b6a134d6
</span>5988c0064 is described below
<span style='display:block; white-space:pre;color:#808000;'>commit 5988c006492023be222bb4545835080ce04a8508
</span>Author: Clemens Lang <neverpanic@gmail.com>
AuthorDate: Thu Jan 25 13:06:41 2024 +0100
<span style='display:block; white-space:pre;color:#404040;'> macports.tcl: Fix regression in 5b6a134d6
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> 5b6a134d66000ca1549ea218850307ef9ae37943 caused dependencies to be
</span><span style='display:block; white-space:pre;color:#404040;'> installed that were not actually required when -s was used. For example,
</span><span style='display:block; white-space:pre;color:#404040;'> with iperf (and thus its runtime dependencies) and cmake (its only
</span><span style='display:block; white-space:pre;color:#404040;'> build-time dependency) installed, running sudo port -st install
</span><span style='display:block; white-space:pre;color:#404040;'> --unrequested iperf would start to install gperf and cmake-bootstrap,
</span><span style='display:block; white-space:pre;color:#404040;'> even though they were not required.
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> It seems this happened because MacPorts did not longer correctly detect
</span><span style='display:block; white-space:pre;color:#404040;'> that the build dependency was actually installed and proceeded to
</span><span style='display:block; white-space:pre;color:#404040;'> install and upgrade all its dependencies.
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> Thanks to halabund and Schamschula for the report.
</span>---
src/macports1.0/macports.tcl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
<span style='display:block; white-space:pre;color:#808080;'>diff --git a/src/macports1.0/macports.tcl b/src/macports1.0/macports.tcl
</span><span style='display:block; white-space:pre;color:#808080;'>index bd8f38a73..e4b883f6e 100644
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>--- a/src/macports1.0/macports.tcl
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>+++ b/src/macports1.0/macports.tcl
</span><span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -2445,7 +2445,7 @@ proc mportexec {mport target} {
</span> registry::exclusive_lock
# see if we actually need to build this port
if {$target ni {activate install} ||
<span style='display:block; white-space:pre;background:#ffe0e0;'>- ![$workername eval [list registry_exists \$subport \$version \$revision \$portvariants]]} {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ ![$workername eval {registry_exists $subport $version $revision $portvariants}]} {
</span>
# upgrade dependencies that are already installed
if {![macports::global_option_isset ports_nodeps]} {
</pre><pre style='margin:0'>
</pre>