<pre style='margin:0'>
Joshua Root (jmroot) pushed a commit to branch master
in repository macports-base.
</pre>
<p><a href="https://github.com/macports/macports-base/commit/103498a9d8ceef14c3f756516c77ae89696387ab">https://github.com/macports/macports-base/commit/103498a9d8ceef14c3f756516c77ae89696387ab</a></p>
<pre style="white-space: pre; background: #F8F8F8"><span style='display:block; white-space:pre;color:#808000;'>commit 103498a9d8ceef14c3f756516c77ae89696387ab
</span>Author: Joshua Root <jmr@macports.org>
AuthorDate: Sun Feb 11 05:34:28 2024 +1100
<span style='display:block; white-space:pre;color:#404040;'> portclient::progress: use lassign
</span>---
src/port/port.tcl | 52 +++++++++++++++++++++++-----------------------------
1 file changed, 23 insertions(+), 29 deletions(-)
<span style='display:block; white-space:pre;color:#808080;'>diff --git a/src/port/port.tcl b/src/port/port.tcl
</span><span style='display:block; white-space:pre;color:#808080;'>index e09db069a..a7296c4bb 100755
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>--- a/src/port/port.tcl
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>+++ b/src/port/port.tcl
</span><span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -4717,17 +4717,14 @@ namespace eval portclient::progress {
</span> initDelay
}
update {
<span style='display:block; white-space:pre;background:#ffe0e0;'>- # the for loop is a simple hack because Tcl 8.4 doesn't have
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- # lassign
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- foreach {now total} $args {
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- if {[showProgress $now $total] eq "yes"} {
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- set barPrefix " "
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- set barPrefixLen [string length $barPrefix]
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- if {$total != 0} {
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- progressbar $now $total [barWidth $barPrefixLen] $barPrefix
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- } else {
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- unprogressbar [barWidth $barPrefixLen] $barPrefix
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- }
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ lassign $args now total
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if {[showProgress $now $total] eq "yes"} {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ set barPrefix " "
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ set barPrefixLen [string length $barPrefix]
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if {$total != 0} {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ progressbar $now $total [barWidth $barPrefixLen] $barPrefix
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ } else {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ unprogressbar [barWidth $barPrefixLen] $barPrefix
</span> }
}
}
<span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -4768,25 +4765,22 @@ namespace eval portclient::progress {
</span> initDelay
}
update {
<span style='display:block; white-space:pre;background:#ffe0e0;'>- # the for loop is a simple hack because Tcl 8.4 doesn't have
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- # lassign
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- foreach {type total now speed} $args {
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- if {[showProgress $now $total] eq "yes"} {
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- set barPrefix " "
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- set barPrefixLen [string length $barPrefix]
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- if {$total != 0} {
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- set barSuffix [format " speed: %-13s" "[bytesize $speed {} "%.1f"]/s"]
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- set barSuffixLen [string length $barSuffix]
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- set barWidth [barWidth [expr {$barPrefixLen + $barSuffixLen}]]
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- progressbar $now $total $barWidth $barPrefix $barSuffix
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- } else {
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- set barSuffix [format " %-10s speed: %-13s" [bytesize $now {} "%6.1f"] "[bytesize $speed {} "%.1f"]/s"]
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- set barSuffixLen [string length $barSuffix]
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- set barWidth [barWidth [expr {$barPrefixLen + $barSuffixLen}]]
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ lassign $args type total now speed
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if {[showProgress $now $total] eq "yes"} {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ set barPrefix " "
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ set barPrefixLen [string length $barPrefix]
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if {$total != 0} {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ set barSuffix [format " speed: %-13s" "[bytesize $speed {} "%.1f"]/s"]
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ set barSuffixLen [string length $barSuffix]
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ set barWidth [barWidth [expr {$barPrefixLen + $barSuffixLen}]]
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ progressbar $now $total $barWidth $barPrefix $barSuffix
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ } else {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ set barSuffix [format " %-10s speed: %-13s" [bytesize $now {} "%6.1f"] "[bytesize $speed {} "%.1f"]/s"]
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ set barSuffixLen [string length $barSuffix]
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ set barWidth [barWidth [expr {$barPrefixLen + $barSuffixLen}]]
</span>
<span style='display:block; white-space:pre;background:#ffe0e0;'>- unprogressbar $barWidth $barPrefix $barSuffix
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- }
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ unprogressbar $barWidth $barPrefix $barSuffix
</span> }
}
}
</pre><pre style='margin:0'>
</pre>