<pre style='margin:0'>
Joshua Root (jmroot) pushed a commit to branch master
in repository macports-base.
</pre>
<p><a href="https://github.com/macports/macports-base/commit/7a7b673eb1c82bdca0e7f836458c74170e5fe8b1">https://github.com/macports/macports-base/commit/7a7b673eb1c82bdca0e7f836458c74170e5fe8b1</a></p>
<pre style="white-space: pre; background: #F8F8F8"><span style='display:block; white-space:pre;color:#808000;'>commit 7a7b673eb1c82bdca0e7f836458c74170e5fe8b1
</span>Author: Joshua Root <jmr@macports.org>
AuthorDate: Sat Mar 9 07:53:44 2024 +1100
<span style='display:block; white-space:pre;color:#404040;'> Avoid potential error in set_developer_dir
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> This is triggered by setxcodeinfo reading $developer_dir, and the
</span><span style='display:block; white-space:pre;color:#404040;'> fallback case reads $xcodeversion, which previously might not have been
</span><span style='display:block; white-space:pre;color:#404040;'> set yet.
</span>---
src/macports1.0/macports.tcl | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
<span style='display:block; white-space:pre;color:#808080;'>diff --git a/src/macports1.0/macports.tcl b/src/macports1.0/macports.tcl
</span><span style='display:block; white-space:pre;color:#808080;'>index cf03593b7..e479274cb 100644
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>--- a/src/macports1.0/macports.tcl
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>+++ b/src/macports1.0/macports.tcl
</span><span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -547,6 +547,8 @@ proc macports::setxcodeinfo {name1 name2 op} {
</span> set xcodeversion_overridden [info exists xcodeversion]
set xcodebuildcmd_overridden [info exists xcodebuildcmd]
<span style='display:block; white-space:pre;background:#e0ffe0;'>+ # Potentially read by developer_dir trace proc
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ set xcodeversion {}
</span> # First try the cache
set xcodeinfo_cache [load_cache xcodeinfo]
# Figure out which file to check to see if Xcode was updated
<span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -746,7 +748,9 @@ proc macports::set_developer_dir {name1 name2 op} {
</span> # Try the default
variable os_major
variable xcodeversion
<span style='display:block; white-space:pre;background:#ffe0e0;'>- if {$os_major >= 11 && [vercmp $xcodeversion 4.3] >= 0} {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if {$os_major >= 11 && ([vercmp $xcodeversion 4.3] >= 0 ||
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ ($xcodeversion eq {} && [file exists /Applications/Xcode.app/Contents/Developer]))
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ } {
</span> set developer_dir /Applications/Xcode.app/Contents/Developer
} else {
set developer_dir /Developer
</pre><pre style='margin:0'>
</pre>