<pre style='margin:0'>
Mohamed Akram (mohd-akram) pushed a commit to branch master
in repository macports-ports.
</pre>
<p><a href="https://github.com/macports/macports-ports/commit/c0209db7dc40c73e26ea3d57ae180afb8b71b55b">https://github.com/macports/macports-ports/commit/c0209db7dc40c73e26ea3d57ae180afb8b71b55b</a></p>
<pre style="white-space: pre; background: #F8F8F8">The following commit(s) were added to refs/heads/master by this push:
<span style='display:block; white-space:pre;color:#404040;'> new c0209db7dc4 nodejs18: update to 18.20.5
</span>c0209db7dc4 is described below
<span style='display:block; white-space:pre;color:#808000;'>commit c0209db7dc40c73e26ea3d57ae180afb8b71b55b
</span>Author: Mohamed Akram <makr@macports.org>
AuthorDate: Wed Dec 4 20:11:54 2024 +0400
<span style='display:block; white-space:pre;color:#404040;'> nodejs18: update to 18.20.5
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> - fix linking with ICU
</span>---
devel/nodejs18/Portfile | 12 ++++++------
devel/nodejs18/files/patch-configure.diff | 27 +++++++++++++++++++++++++++
2 files changed, 33 insertions(+), 6 deletions(-)
<span style='display:block; white-space:pre;color:#808080;'>diff --git a/devel/nodejs18/Portfile b/devel/nodejs18/Portfile
</span><span style='display:block; white-space:pre;color:#808080;'>index e2e64885a55..539f8aa495e 100644
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>--- a/devel/nodejs18/Portfile
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>+++ b/devel/nodejs18/Portfile
</span><span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -8,11 +8,10 @@ configure.cxx_stdlib libc++
</span> compiler.cxx_standard 2014
name nodejs18
<span style='display:block; white-space:pre;background:#ffe0e0;'>-version 18.20.4
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+version 18.20.5
</span> revision 0
categories devel net
<span style='display:block; white-space:pre;background:#ffe0e0;'>-platforms darwin
</span> license {MIT BSD}
maintainers {ciserlohn @ci42} openmaintainer
<span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -29,9 +28,9 @@ homepage https://nodejs.org/
</span> master_sites ${homepage}dist/v${version}
use_xz yes
<span style='display:block; white-space:pre;background:#ffe0e0;'>-checksums rmd160 259574fd6b765b08aba88b4829ca06231cb8cd74 \
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- sha256 a76c7ea1b96aeb6963a158806260c8094b6244d64a696529d020547b9a95ca2a \
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- size 40445740
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+checksums rmd160 60d93c8ec8ca045341e26120636180da3463055b \
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ sha256 76037b9bad0ab9396349282dbfcec1b872ff7bd8c8d698853bebd982940858bf \
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ size 40624172
</span>
distname node-v${version}
<span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -74,7 +73,8 @@ proc rec_glob {basedir pattern} {
</span>
configure.python ${prefix}/bin/python${py_ver}
<span style='display:block; white-space:pre;background:#ffe0e0;'>-patchfiles patch-common.gypi.diff
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+patchfiles patch-common.gypi.diff \
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ patch-configure.diff
</span>
post-patch {
foreach f [concat ${worksrcpath}/configure \
<span style='display:block; white-space:pre;color:#808080;'>diff --git a/devel/nodejs18/files/patch-configure.diff b/devel/nodejs18/files/patch-configure.diff
</span>new file mode 100644
<span style='display:block; white-space:pre;color:#808080;'>index 00000000000..dddd21739b8
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>--- /dev/null
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>+++ b/devel/nodejs18/files/patch-configure.diff
</span><span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -0,0 +1,27 @@
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+From 54299ac3a3d4e4520b8604dce43c2584092ccde2 Mon Sep 17 00:00:00 2001
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+From: Michael Cho <michael@michaelcho.dev>
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+Date: Sun, 27 Oct 2024 10:08:07 -0400
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+Subject: [PATCH] build: fix building with system icu 76
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ICU 76 decided to reduce overlinking[^1] thus `icu-i18n` will no longer
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+add `icu-uc` when linking to shared libraries. This results in undefined
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+symbols/references when trying to build with system ICU 76.
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+[^1]: unicode-org/icu@199bc82
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+---
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ configure.py | 2 +-
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ 1 file changed, 1 insertion(+), 1 deletion(-)
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+diff --git a/configure.py b/configure.py
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+index a5f47af1748903..a4e210261e2e76 100755
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+--- configure.py
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++++ configure.py
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+@@ -1763,7 +1763,7 @@ def icu_download(path):
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ elif with_intl == 'system-icu':
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ # ICU from pkg-config.
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ o['variables']['v8_enable_i18n_support'] = 1
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+- pkgicu = pkg_config('icu-i18n')
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>++ pkgicu = pkg_config(['icu-i18n', 'icu-uc'])
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if not pkgicu[0]:
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ error('''Could not load pkg-config data for "icu-i18n".
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ See above errors or the README.md.''')
</span></pre><pre style='margin:0'>
</pre>