<pre style='margin:0'>
Clemens Lang (neverpanic) pushed a commit to branch master
in repository macports-base.
</pre>
<p><a href="https://github.com/macports/macports-base/commit/1b43b563cf14d7b1b2e3d6d43e1c76de577f218a">https://github.com/macports/macports-base/commit/1b43b563cf14d7b1b2e3d6d43e1c76de577f218a</a></p>
<pre style="white-space: pre; background: #F8F8F8">The following commit(s) were added to refs/heads/master by this push:
<span style='display:block; white-space:pre;color:#404040;'> new 1b43b563c programs/cp: Avoid allocation
</span>1b43b563c is described below
<span style='display:block; white-space:pre;color:#808000;'>commit 1b43b563cf14d7b1b2e3d6d43e1c76de577f218a
</span>Author: Clemens Lang <cal@macports.org>
AuthorDate: Sun Dec 8 22:10:07 2024 +0100
<span style='display:block; white-space:pre;color:#404040;'> programs/cp: Avoid allocation
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> We can use the stack instead. Thanks @raimue for spotting that.
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> See https://github.com/macports/macports-base/pull/356#issuecomment-2525211335.
</span>---
src/programs/cp/cp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
<span style='display:block; white-space:pre;color:#808080;'>diff --git a/src/programs/cp/cp.c b/src/programs/cp/cp.c
</span><span style='display:block; white-space:pre;color:#808080;'>index f322ce09e..b4dc44223 100644
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>--- a/src/programs/cp/cp.c
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>+++ b/src/programs/cp/cp.c
</span><span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -8,10 +8,10 @@
</span>
int main(int argc, char *argv[])
{
<span style='display:block; white-space:pre;background:#ffe0e0;'>- char *cp_path = strdup("/bin/cp");
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- char *clone_arg = strdup("-c");
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ char cp_path[] = "/bin/cp";
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ char clone_arg[] = "-c";
</span> char **new_argv = malloc(sizeof(char *) * (argc+2));
<span style='display:block; white-space:pre;background:#ffe0e0;'>- if (cp_path && clone_arg && new_argv) {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if (new_argv) {
</span> new_argv[0] = cp_path;
new_argv[1] = clone_arg;
for (int i = 1; i <= argc; i++) {
</pre><pre style='margin:0'>
</pre>