<pre style='margin:0'>
Christopher Nielsen (mascguy) pushed a commit to branch master
in repository macports-legacy-support.
</pre>
<p><a href="https://github.com/macports/macports-legacy-support/commit/975846f8e706ac8ca9065dc23ed2bf2d8f3b0921">https://github.com/macports/macports-legacy-support/commit/975846f8e706ac8ca9065dc23ed2bf2d8f3b0921</a></p>
<pre style="white-space: pre; background: #F8F8F8"><span style='display:block; white-space:pre;color:#808000;'>commit 975846f8e706ac8ca9065dc23ed2bf2d8f3b0921
</span>Author: Fred Wright <fw@fwright.net>
AuthorDate: Tue Jan 14 14:28:26 2025 -0800
<span style='display:block; white-space:pre;color:#404040;'> test_copyfile: Remove 10.4 Rosetta exception.
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> This almost reverts commit 4e3779a, but retains the better test_flags
</span><span style='display:block; white-space:pre;color:#404040;'> setup.
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> TESTED:
</span><span style='display:block; white-space:pre;color:#404040;'> Without fix, fails on 10.4 Rosetta and passes on all others.
</span><span style='display:block; white-space:pre;color:#404040;'> With fix, passes on all platforms, including 10.4 Rosetta.
</span>---
test/test_copyfile.c | 27 ---------------------------
1 file changed, 27 deletions(-)
<span style='display:block; white-space:pre;color:#808080;'>diff --git a/test/test_copyfile.c b/test/test_copyfile.c
</span><span style='display:block; white-space:pre;color:#808080;'>index 27d779c..3cef097 100644
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>--- a/test/test_copyfile.c
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>+++ b/test/test_copyfile.c
</span><span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -29,11 +29,6 @@
</span>
#include <sys/param.h>
#include <sys/stat.h>
<span style='display:block; white-space:pre;background:#ffe0e0;'>-#include <sys/sysctl.h>
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-#include <sys/types.h>
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-/* sysctl to check whether we're running natively (not Rosetta) */
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-#define SYSCTL_NATIVE "sysctl.proc_native"
</span>
/* Set up condition for testing the compatibility wrappers. */
#if !defined(__ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__) \
<span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -63,23 +58,6 @@ typedef struct dummy_ctx_s {
</span> int dummy;
} dummy_ctx_t;
<span style='display:block; white-space:pre;background:#ffe0e0;'>-/*
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- * 10.4 Rosetta is unable to handle COPYFILE_ACL, so we need to check.
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- */
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-#if TEST_TIGER && defined(__ppc__)
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-static int
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-arch_ok(void)
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-{
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- int val = 0;
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- size_t vsiz = sizeof(val);
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- if (sysctlbyname(SYSCTL_NATIVE, &val, &vsiz, NULL, 0) < 0) return -1;
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- return val;
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-}
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-#else /* not possibly 10.4 Rosetta */
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-static int arch_ok(void) { return 1;}
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-#endif
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-
</span> int
main(int argc, char *argv[])
{
<span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -114,11 +92,6 @@ main(int argc, char *argv[])
</span> }
}
<span style='display:block; white-space:pre;background:#ffe0e0;'>- if (!arch_ok()) {
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- if (verbose) printf(" Avoiding COPYFILE_ACL due to Rosetta bug\n");
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- test_flags &= ~COPYFILE_ACL;
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>- }
</span><span style='display:block; white-space:pre;background:#ffe0e0;'>-
</span> if (stat(argv[0], &ourstat)) {
perror("unable to stat() self");
return 1;
</pre><pre style='margin:0'>
</pre>