<pre style='margin:0'>
Joshua Root (jmroot) pushed a commit to branch master
in repository macports-base.
</pre>
<p><a href="https://github.com/macports/macports-base/commit/a29efb740770c9890926653a83ad4f83030d314b">https://github.com/macports/macports-base/commit/a29efb740770c9890926653a83ad4f83030d314b</a></p>
<pre style="white-space: pre; background: #F8F8F8"><span style='display:block; white-space:pre;color:#808000;'>commit a29efb740770c9890926653a83ad4f83030d314b
</span>Author: Joshua Root <jmr@macports.org>
AuthorDate: Mon May 12 19:23:45 2025 +1000
<span style='display:block; white-space:pre;color:#404040;'> lint: only check for default platforms with no subports
</span><span style='display:block; white-space:pre;color:#404040;'>
</span><span style='display:block; white-space:pre;color:#404040;'> Closes: https://github.com/macports/macports-base/pull/358
</span>---
src/port1.0/portlint.tcl | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
<span style='display:block; white-space:pre;color:#808080;'>diff --git a/src/port1.0/portlint.tcl b/src/port1.0/portlint.tcl
</span><span style='display:block; white-space:pre;color:#808080;'>index 9c58b8039..449b405b8 100644
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>--- a/src/port1.0/portlint.tcl
</span><span style='display:block; white-space:pre;background:#e0e0ff;'>+++ b/src/port1.0/portlint.tcl
</span><span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -260,7 +260,7 @@ proc portlint::lint_platforms {platforms} {
</span> set errors [list]
set warnings [list]
<span style='display:block; white-space:pre;background:#ffe0e0;'>- global lint_platforms subport name
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ global lint_platforms name subport PortInfo
</span>
foreach platform $platforms {
set platname [lindex $platform 0]
<span style='display:block; white-space:pre;background:#e0e0e0;'>@@ -269,7 +269,11 @@ proc portlint::lint_platforms {platforms} {
</span> }
}
<span style='display:block; white-space:pre;background:#ffe0e0;'>- if {$platforms eq "darwin" && [string equal -nocase $name $subport]} {
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ # Skip if there are any subports in the Portfile, as lint is not smart
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ # enough to know which platforms line belongs to which subport.
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ if {$platforms eq "darwin" && [string equal -nocase $name $subport]
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ && (![info exists PortInfo(subports)] || $PortInfo(subports) eq {})
</span><span style='display:block; white-space:pre;background:#e0ffe0;'>+ } then {
</span> lappend warnings "Unnecessary platforms line as darwin is the default"
}
</pre><pre style='margin:0'>
</pre>