[macports-ports] branch master updated: minetest: new port

[Ryan Schmidt]

On Dec 8, 2017, at 18:12, Ken wrote:

> Ken (kencu) pushed a commit to branch master
> in repository macports-ports.
> 
> 
> https://github.com/macports/macports-ports/commit/202574ece6f47a67aaa67eda85b4fced6e37f0ca
> 
> The following commit(s) were added to refs/heads/master by this push:
> 
>      new 202574e  minetest: new port
> 
> 202574e is described below
> 
> 
> commit 202574ece6f47a67aaa67eda85b4fced6e37f0ca
> 
> Author: kencu
> AuthorDate: Fri Dec 8 16:12:58 2017 -0800
> 
> 
>     minetest: new port
> 
>     
> 
>     Reportedly the most popular open-source game
>     on the internet today.
> 
> ---
>  games/minetest/Portfile                            | 69 ++++++++++++++++++++++


> +# also need the minetest game
> +
> +post-extract {
> + system -W ${worksrcpath} "curl --output minetest-game.tar.gz https://codeload.github.com/minetest/minetest_game/tar.gz/${version}"
> + system -W ${worksrcpath} "tar xvf minetest-game.tar.gz"
> + system -W ${worksrcpath} "mv minetest_game-${version} minetest_game"
> +}

Please don't fetch files in the extract phase. Fetch in the fetch phase.

Please don't fetch files manually if possible. Instead, use the existing MacPorts mechanisms for downloading multiple files (distfiles, master_sites, :tags).

This whitespace does not conform to the modeline. Indent at multiples of 4 spaces.


> +depends_lib-append      port:irrlicht \
> +                        port:jpeg \
> +                        port:libogg \
> +                        port:libvorbis \
> +                        port:freetype \
> +                        port:gettext \
> +                        port:leveldb \
> +                        port:hiredis \
> +                        port:curl \
> +                        port:luajit \
> +                        port:jsoncpp \
> +                        port:doxygen

Is doxygen really a library dependency? Usually it is only used to build documentation.


> +configure.args-append   -DCMAKE_BUILD_TYPE=Release \

Is the cmake 1.1 portgroup's default build type of "MacPorts" not compatible with this port?


> +                        -DCMAKE_INSTALL_PREFIX:PATH=${applications_dir} \
> +                        -DBUILD_CLIENT=1 \
> +                        -DENABLE_SOUND=1 \
> +                        -DENABLE_REDIS=1 \
> +                        -DENABLE_LEVELDB=1 \
> +                        -DENABLE_FREETYPE=1 \
> +                        -DENABLE_CURL=1 \
> +                        -DENABLE_GETTEXT=1 \
> +                        -DENABLE_SYSTEM_JSONCPP=1 \
> +                        -DIRRLICHT_LIBRARY:FILEPATH=${prefix}/Library/Frameworks/IrrFramework.framework/IrrFramework \

Please use ${frameworks_dir} here instead of assuming it's ${prefix}/Library/Frameworks.

Actually, since below you're using `-DIRRLICHT_INCLUDE_DIR:FILEPATH=${prefix}/include/irrlicht`, wouldn't it be more consistent to use `-DIRRLICHT_LIBRARY:FILEPATH=${prefix}/lib/libIrrlicht.dylib`? Either use the framework path for both or for neither, but not for just one.


> +                        -DIRRLICHT_INCLUDE_DIR:FILEPATH=${prefix}/include/irrlicht \
> +                        -DCURSES_INCLUDE_PATH:FILEPATH=${prefix}/include \
> +                        -DENABLE_LUAJIT=ON \
> +                        -DLUA_INCLUDE_DIR:PATH=${prefix}/include/luajit-2.0 \
> +                        -DLUA_LIBRARY:FILEPATH=${prefix}/lib/libluajit-5.1.dylib