<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div></div><div>For those who use GitHub, you can add ?w=1 to the end of a url that shows a diff to not show white space differences. </div><div>Sterling <br>On Oct 7, 2017, at 5:15 PM, Ryan Schmidt <<a href="mailto:ryandesign@macports.org">ryandesign@macports.org</a>> wrote:<br><br></div><blockquote type="cite"><div><span></span><br><blockquote type="cite"><span>On Oct 6, 2017, at 20:34, Marius Schamschula <<a href="mailto:mps@macports.org">mps@macports.org</a>> wrote:</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>Marius Schamschula (Schamschula) pushed a commit to branch master</span><br></blockquote><blockquote type="cite"><span>in repository macports-ports.</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span><a href="https://github.com/macports/macports-ports/commit/fe0730636309d31fbee348f1384702ba3c90b35c">https://github.com/macports/macports-ports/commit/fe0730636309d31fbee348f1384702ba3c90b35c</a></span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>commit fe0730636309d31fbee348f1384702ba3c90b35c</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>Author: Marius Schamschula <<a href="mailto:mps@macports.org">mps@macports.org</a>></span><br></blockquote><blockquote type="cite"><span>AuthorDate: Fri Oct 6 20:34:48 2017 -0500</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span> ghostscript 9.22: rev bump dependents</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span> fix whitespace and add modeline, where missing</span><br></blockquote><span></span><br><span></span><br><span>If a port already conforms to the modeline but doesn't have one, you can add it while doing other changes; other minor changes, like obfuscating email addresses or adding GitHub handles to maintainers are fine too.</span><br><span></span><br><span>But it would be best in the future to make whitespace changes separately from functional changes, so that those diffs, which can get large and can affect every line of a Portfile, can be safely ignored by reviewers. Such a commit is also a good time to add or correct the modeline.</span><br><span></span><br><span></span><br><blockquote type="cite"><span>-- a/science/gmt5/Portfile</span><br></blockquote><blockquote type="cite"><span>+++ b/science/gmt5/Portfile</span><br></blockquote><blockquote type="cite"><span>@@ -5,9 +5,11 @@ PortGroup cmake 1.0</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span> name gmt5</span><br></blockquote><blockquote type="cite"><span> version 5.4.2</span><br></blockquote><blockquote type="cite"><span>+revision 1</span><br></blockquote><blockquote type="cite"><span> categories science</span><br></blockquote><blockquote type="cite"><span> platforms darwin</span><br></blockquote><blockquote type="cite"><span>-maintainers takeshi</span><br></blockquote><blockquote type="cite"><span>+maintainers <a href="http://eprofs.de">eprofs.de</a>:florian \</span><br></blockquote><blockquote type="cite"><span>+ takeshi</span><br></blockquote><blockquote type="cite"><span> license GPL-3</span><br></blockquote><blockquote type="cite"><span> description The Generic Mapping Tools</span><br></blockquote><blockquote type="cite"><span> long_description GMT is an open source collection of ~120 tools \</span><br></blockquote><blockquote type="cite"><span>@@ -28,6 +30,10 @@ master_sites <a href="ftp://ftp.soest.hawaii.edu/gmt">ftp://ftp.soest.hawaii.edu/gmt</a> \</span><br></blockquote><blockquote type="cite"><span> use_xz yes</span><br></blockquote><blockquote type="cite"><span> distname gmt-${version}</span><br></blockquote><blockquote type="cite"><span> distfiles ${distname}-src${extract.suffix}</span><br></blockquote><blockquote type="cite"><span>+</span><br></blockquote><blockquote type="cite"><span>+# stealth update </span><br></blockquote><blockquote type="cite"><span>+dist_subdir ${name}/${version}_1</span><br></blockquote><blockquote type="cite"><span>+</span><br></blockquote><blockquote type="cite"><span> checksums rmd160 ed90b3b46aeb98b7d5ed9bb0c68fbf7ebf7df929 \</span><br></blockquote><blockquote type="cite"><span> sha256 ddcd63094aeda5a60f541626ed7ab4a78538d52dea24ba915f168e4606e587f5</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><span></span><br><span>This doesn't look intentional. It re-adds Florain as maintainer (you deliberately removed him in <a href="https://github.com/macports/macports-ports/commit/7d2e2673c27b3cbbf9266dd1a4e49f77682ef33f">https://github.com/macports/macports-ports/commit/7d2e2673c27b3cbbf9266dd1a4e49f77682ef33f</a>) and changes the dist_subdir even though the checksums were not changed, so there wasn't a stealth update.</span><br><span></span><br><span></span><br><span></span><br></div></blockquote></body></html>