<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 2018-04-28 00:34, Marcus
Calhoun-Lopez wrote:<br>
</div>
<blockquote type="cite"
cite="mid:20180427223431.B8C872A61B2@braeburn.macports.org">
<pre style="margin:0">Marcus Calhoun-Lopez (MarcusCalhoun-Lopez) pushed a commit to branch master
in repository macports-ports.
</pre>
<p><a
href="https://github.com/macports/macports-ports/commit/24864aeda99bedbc183f882878df70e8b555aa0b"
moz-do-not-send="true">https://github.com/macports/macports-ports/commit/24864aeda99bedbc183f882878df70e8b555aa0b</a></p>
<pre style="white-space: pre; background: #F8F8F8"><span style="display:block; white-space:pre;color:#808000;">commit 24864aeda99bedbc183f882878df70e8b555aa0b
</span>Author: Marcus Calhoun-Lopez <a class="moz-txt-link-rfc2396E" href="mailto:mcalhoun@macports.org"><mcalhoun@macports.org></a>
AuthorDate: Fri Apr 27 15:33:16 2018 -0700
<span style="display:block; white-space:pre;color:#404040;"> fd: use new features of cargo PG
</span>---
sysutils/fd/Portfile | 35 +++++++++++++++++++----------------
1 file changed, 19 insertions(+), 16 deletions(-)
<span style="display:block; white-space:pre;color:#808080;">diff --git a/sysutils/fd/Portfile b/sysutils/fd/Portfile
</span><span style="display:block; white-space:pre;color:#808080;">index 5100103..c5ca61c 100644
</span><span style="display:block; white-space:pre;background:#e0e0ff;">--- a/sysutils/fd/Portfile
</span><span style="display:block; white-space:pre;background:#e0e0ff;">+++ b/sysutils/fd/Portfile
</span><span style="display:block; white-space:pre;background:#e0e0e0;">@@ -22,6 +22,8 @@ checksums fd-${version}.tar.gz \
</span> sha256 e6ba21e66a295b9fb69bfc9a361813b3c7d73b8d29dc819d37d21af750814ee9 \
size 49655
<span style="display:block; white-space:pre;background:#e0ffe0;">+cargo.direct_call yes</span></pre>
</blockquote>
"direct_call"? What is this supposed to mean?<br>
<blockquote type="cite"
cite="mid:20180427223431.B8C872A61B2@braeburn.macports.org">
<pre style="margin:0"><span style="display:block; white-space:pre;background:#e0ffe0;">
</span><span style="display:block; white-space:pre;background:#e0ffe0;">+
</span> cargo.crates \
aho-corasick 0.6.4 d6531d44de723825aa81398a6415283229725a00fa30713812ab9323faa82fc4 \
ansi_term 0.11.0 ee49baf6cb617b853aa8d93bf420db2383fab46d314482ca2803b40d5fde979b \
<span style="display:block; white-space:pre;background:#e0e0e0;">@@ -79,22 +81,23 @@ pre-build {
</span>
build.env-append SHELL_COMPLETIONS_DIR="${worksrcpath}/shell_completions"
<span style="display:block; white-space:pre;background:#ffe0e0;">-destroot {
</span><span style="display:block; white-space:pre;background:#ffe0e0;">- xinstall -m 755 ${worksrcpath}/target/release/${name} ${destroot}${prefix}/bin/
</span><span style="display:block; white-space:pre;background:#ffe0e0;">- xinstall -m 444 ${worksrcpath}/doc/${name}.1 ${destroot}${prefix}/share/man/man1/
</span><span style="display:block; white-space:pre;background:#e0ffe0;">+# muniversal build requires Makefile
</span><span style="display:block; white-space:pre;background:#e0ffe0;">+destroot.args-append -f Makefile-Install
</span><span style="display:block; white-space:pre;background:#e0ffe0;">+post-extract {
</span><span style="display:block; white-space:pre;background:#e0ffe0;">+ set makefile [open ${worksrcpath}/Makefile-Install "w"]
</span><span style="display:block; white-space:pre;background:#e0ffe0;">+ puts ${makefile} "install:"
</span><span style="display:block; white-space:pre;background:#e0ffe0;">+ puts ${makefile} "\tinstall -m 0755 target/\$(CARGO_BUILD_TARGET)/release/${name} \$(DESTDIR)${prefix}/bin"
</span><span style="display:block; white-space:pre;background:#e0ffe0;">+ puts ${makefile} "\tinstall -m 0444 doc/${name}.1 \$(DESTDIR)${prefix}/share/man/man1/"
</span><span style="display:block; white-space:pre;background:#e0ffe0;">+
</span><span style="display:block; white-space:pre;background:#e0ffe0;">+ puts ${makefile} "\tinstall -d -m 0755 \$(DESTDIR)${prefix}/share/doc/${name}"
</span><span style="display:block; white-space:pre;background:#e0ffe0;">+ puts ${makefile} "\tinstall -m 0644 README.md LICENSE-MIT LICENSE-APACHE \$(DESTDIR)${prefix}/share/doc/${name}"
</span>
<span style="display:block; white-space:pre;background:#ffe0e0;">- xinstall -d ${destroot}${prefix}/share/doc/${name}
</span><span style="display:block; white-space:pre;background:#ffe0e0;">- xinstall -m 644 -W ${worksrcpath} \
</span><span style="display:block; white-space:pre;background:#ffe0e0;">- README.md LICENSE-MIT LICENSE-APACHE \
</span><span style="display:block; white-space:pre;background:#ffe0e0;">- ${destroot}${prefix}/share/doc/${name}
</span><span style="display:block; white-space:pre;background:#e0ffe0;">+ puts ${makefile} "\tinstall -d -m 0755 \$(DESTDIR)${prefix}/share/bash-completion/completions"
</span><span style="display:block; white-space:pre;background:#e0ffe0;">+ puts ${makefile} "\tinstall -m 644 ${worksrcpath}/shell_completions/fd.bash \$(DESTDIR)${prefix}/share/bash-completion/completions/fd"
</span><span style="display:block; white-space:pre;background:#e0ffe0;">+ puts ${makefile} "\tinstall -d -m 0755 \$(DESTDIR)${prefix}/share/zsh/site-functions"
</span><span style="display:block; white-space:pre;background:#e0ffe0;">+ puts ${makefile} "\tinstall -m 644 ${worksrcpath}/shell_completions/_fd \$(DESTDIR)${prefix}/share/zsh/site-functions/_fd"
</span><span style="display:block; white-space:pre;background:#e0ffe0;">+ puts ${makefile} "\tinstall -d -m 0755 \$(DESTDIR)${prefix}/share/fish/completions"
</span><span style="display:block; white-space:pre;background:#e0ffe0;">+ puts ${makefile} "\tinstall -m 644 ${worksrcpath}/shell_completions/fd.fish \$(DESTDIR)${prefix}/share/fish/completions/fd.fish"
</span>
<span style="display:block; white-space:pre;background:#ffe0e0;">- xinstall -d ${destroot}${prefix}/share/bash-completion/completions
</span><span style="display:block; white-space:pre;background:#ffe0e0;">- xinstall -m 644 ${worksrcpath}/shell_completions/fd.bash \
</span><span style="display:block; white-space:pre;background:#ffe0e0;">- ${destroot}${prefix}/share/bash-completion/completions/fd
</span><span style="display:block; white-space:pre;background:#ffe0e0;">- xinstall -d ${destroot}${prefix}/share/zsh/site-functions
</span><span style="display:block; white-space:pre;background:#ffe0e0;">- xinstall -m 644 ${worksrcpath}/shell_completions/_fd \
</span><span style="display:block; white-space:pre;background:#ffe0e0;">- ${destroot}${prefix}/share/zsh/site-functions/_fd
</span><span style="display:block; white-space:pre;background:#ffe0e0;">- xinstall -d ${destroot}${prefix}/share/fish/completions
</span><span style="display:block; white-space:pre;background:#ffe0e0;">- xinstall -m 644 ${worksrcpath}/shell_completions/fd.fish \
</span><span style="display:block; white-space:pre;background:#ffe0e0;">- ${destroot}${prefix}/share/fish/completions/fd.fish
</span><span style="display:block; white-space:pre;background:#e0ffe0;">+ close ${makefile}
</span> }
</pre>
</blockquote>
I do not understand why you would need a Makefile? The destroot
phase seemed totally fine?<br>
<br>
If muniversal cannot work with destroot {} please fix muniversal, or
disable +universal for this port. I do not want to maintain such a
hack.<br>
<p>Rainer<br>
</p>
</body>
</html>