<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On 2018-05-25, at 8:38 AM, Ryan Schmidt wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div><br>On May 24, 2018, at 23:15, Ken wrote:<br><br><font class="Apple-style-span" color="#006312"><br></font>If this is supposed to help 10.6...<br><br><br><blockquote type="cite">+@@ -197,6 +197,8 @@</blockquote><blockquote type="cite">+ v = float('.'.join(v.split('.')[:2]))<br></blockquote><blockquote type="cite">+ if v >= 10.12:<br></blockquote><blockquote type="cite">+ extra_compile_args.append('-std=c++11')<br></blockquote><blockquote type="cite">++ extra_compile_args.append('@@MACPORTS_STDLIB@@')<br></blockquote><blockquote type="cite">++ extra_compile_args.append('@@MACPORTS_EXTRAARG@@')<br></blockquote><br>...why is it inside an if statement that's for 10.12 and later?<br></div></blockquote><div><br></div><div><br></div><div>Yeah, their logic for the test must be busted. My guess is that testing for 10.12 passes everything 10.1 and above, but I defer to someone who can read python. Can you fix that v.float () business for them?</div><div><br></div><div><br></div><br><blockquote type="cite"><div><br>I guess it works because the if statement is erroneously treating the version number as a floating point number, in which case 10.6 is considered to be greater than 10.12.<br><br>So the question is: does this code always require C++11?</div></blockquote><div><br></div><div>Probably. protobuf3-cpp seems to, and this port errors otherwise with the errors noted in the ticket.</div><div><br></div><div><br></div><br><blockquote type="cite"><div> If so, remove the if statement.<br><br>If it does not always require C++11, fix the if statement so that it correctly uses C++11 only on 10.12 and later.<br><br><br></div></blockquote></div><br><div>I don't grok python very deeply, I"m afraid.</div><div><br></div><div>What I did fixes it for us -- but I agree there is something busted in that build.</div><div><br></div><div>I can revert the fixes if you like.</div><div><br></div><div><br></div><div><br></div><div>Ken</div></body></html>