<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#333333">
<p><font face="Arial">Thanks Chris,</font><br>
</p>
<br>
<div class="moz-cite-prefix">On 1/27/19 12:41 , Christopher Jones
wrote:<br>
</div>
<blockquote
cite="mid:3E6CF147-2F44-42A4-964E-7EB079DB845E@hep.phy.cam.ac.uk"
type="cite">
<blockquote type="cite" class="">
<div class="">
<div bgcolor="#FFFFFF" text="#333333" class=""><tt class="">So,
I'd like to ask… Where to put it?</tt><tt class=""><br
class="">
</tt></div>
</div>
</blockquote>
<div><br class="">
</div>
<div>The port group code lives in the same GitHub project as the
ports. See</div>
<div><br class="">
</div>
<div><a moz-do-not-send="true"
href="https://github.com/macports/macports-ports/tree/b7dbaee30cd63f197eb8d1b0db9090a5a5c948f4/_resources/port1.0/group"
class="">https://github.com/macports/macports-ports/tree/b7dbaee30cd63f197eb8d1b0db9090a5a5c948f4/_resources/port1.0/group</a></div>
<div><br class="">
</div>
<div>New port groups should just be added there.</div>
<div><br class="">
</div>
<div>I would also say submissions of new groups should proceed as
PR request just like port updates/submissions.</div>
<div><br class="">
</div>
<div>Chris</div>
</blockquote>
<br>
Yes, so PR it is then?<br>
<br>
Since it more of a head start of the file (works, but I can't decide
if it's ready to go), I was thinking that I maybe I should present
it somewhere, incl my dummy Portfile, and add my notes - what's been
done, and not been done, etc. But, I guess I could add them in a
gist and make ref to that one perhaps?<br>
<br>
Ok, so if a PR - should I add a few labels to it maybe: needs more
testing, draft, wip?<br>
<br>
<br>
<div class="moz-cite-prefix">On 1/27/19 13:03 , Joshua Root wrote:<br>
</div>
<blockquote
cite="mid:32fd47fa-deb0-ffb1-892a-4f5a6b26675e@macports.org"
type="cite">
<pre wrap="">To expand on this, you can mark a PR as WIP until it's ready to merge,
and you can force push to the branch in your fork to update the commits
in the PR.
- Josh</pre>
</blockquote>
Ok, that answers my Q about that (above).<br>
<br>
So, I can leave my comments (in the file), for now?<br>
<br>
- - -<br>
<br>
// Well, I guess when I feel I don't know the full magic of
portfiles, I thought it would be better (good practice) if someone
hade a look/review at it, “pre-PR”. :)<br>
<br>
· Eric<br>
</body>
</html>