<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 27 Jan 2019, at 12:17 pm, Eric F (iEFdev) <<a href="mailto:eric@iefdev.se" class="">eric@iefdev.se</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type" class="">
<div bgcolor="#FFFFFF" text="#333333" class=""><p class=""><font face="Arial" class="">Thanks Chris,</font><br class="">
</p>
<br class="">
<div class="moz-cite-prefix">On 1/27/19 12:41 , Christopher Jones
wrote:<br class="">
</div>
<blockquote cite="mid:3E6CF147-2F44-42A4-964E-7EB079DB845E@hep.phy.cam.ac.uk" type="cite" class="">
<blockquote type="cite" class="">
<div class="">
<div bgcolor="#FFFFFF" text="#333333" class=""><tt class="">So,
I'd like to ask… Where to put it?</tt><tt class=""><br class="">
</tt></div>
</div>
</blockquote>
<div class=""><br class="">
</div>
<div class="">The port group code lives in the same GitHub project as the
ports. See</div>
<div class=""><br class="">
</div>
<div class=""><a moz-do-not-send="true" href="https://github.com/macports/macports-ports/tree/b7dbaee30cd63f197eb8d1b0db9090a5a5c948f4/_resources/port1.0/group" class="">https://github.com/macports/macports-ports/tree/b7dbaee30cd63f197eb8d1b0db9090a5a5c948f4/_resources/port1.0/group</a></div>
<div class=""><br class="">
</div>
<div class="">New port groups should just be added there.</div>
<div class=""><br class="">
</div>
<div class="">I would also say submissions of new groups should proceed as
PR request just like port updates/submissions.</div>
<div class=""><br class="">
</div>
<div class="">Chris</div>
</blockquote>
<br class="">
Yes, so PR it is then?<br class="">
<br class="">
Since it more of a head start of the file (works, but I can't decide
if it's ready to go), I was thinking that I maybe I should present
it somewhere, incl my dummy Portfile, and add my notes - what's been
done, and not been done, etc. But, I guess I could add them in a
gist and make ref to that one perhaps?<br class="">
<br class="">
Ok, so if a PR - should I add a few labels to it maybe: needs more
testing, draft, wip?<br class=""></div></div></blockquote><div><br class=""></div><div><br class=""></div><div>If you don’t think it is quite ready, but you want to start to get feedback, then that is exactly with WIP PRs are for. Just remember to start the title with ‘WIP” and also add the wip label to the PR.</div><div><br class=""></div>Chris</div><div><br class=""><blockquote type="cite" class=""><div class=""><div bgcolor="#FFFFFF" text="#333333" class="">
<br class="">
<br class="">
<div class="moz-cite-prefix">On 1/27/19 13:03 , Joshua Root wrote:<br class="">
</div>
<blockquote cite="mid:32fd47fa-deb0-ffb1-892a-4f5a6b26675e@macports.org" type="cite" class="">
<pre wrap="" class="">To expand on this, you can mark a PR as WIP until it's ready to merge,
and you can force push to the branch in your fork to update the commits
in the PR.
- Josh</pre>
</blockquote>
Ok, that answers my Q about that (above).<br class="">
<br class="">
So, I can leave my comments (in the file), for now?<br class="">
<br class="">
- - -<br class="">
<br class="">
// Well, I guess when I feel I don't know the full magic of
portfiles, I thought it would be better (good practice) if someone
hade a look/review at it, “pre-PR”. :)<br class="">
<br class="">
· Eric<br class="">
</div>
</div></blockquote></div><br class=""></body></html>