<div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr">Hi</div><div dir="ltr"><br></div><div dir="ltr"><div>For me, this project can be divided into three major parts:</div><div><br></div><div>1. ports page:</div><div><br></div><div>a) We have seen a quick demo of this already. However, the major part I think is missing is the search. We can brainstorm over the details like search-as-you-type, adding new ports etc according to the timeline. Not sure how much browsing by the first letter helps. </div><div><br></div><div>b) You cannot have a class Ports when it represents a Port: <a href="https://github.com/arjunsalyan/MacPorts-Demo-App/blob/master/ports/models.py#L6" target="_blank">https://github.com/arjunsalyan/MacPorts-Demo-App/blob/master/ports/models.py#L6</a>.</div><div><br></div><div>2. build statistics:</div><div><br></div><div>a) In Time Elapsed of builds, it would be incorrect to show time taken for only one of the build stages. Example, in the case of <a href="https://build.macports.org/builders/ports-10.12_x86_64-builder/builds/87301" target="_blank">https://build.macports.org/builders/ports-10.12_x86_64-builder/builds/87301</a>, total-time-taken (12 min 59 secs) is right to be shown and not "6 mins 45 secs".</div><div><br></div><div>b) There are some things which seem hard-coded to me. I see '10.14_x86_64', '10.13_x86_64' at multiple places - in port detail view, build to database view and jinja templates. It's time to define some constants config file now. For build statuses as well. With a new release of macOS, we do not want to have to change multiple files in code. In this project, it is important that a part which works, it is accurate and complete.</div><div><br></div><div>c) Also, as Mojca mentioned, errors like these: <a href="http://frozen-falls-98471.herokuapp.com/ports/database/" target="_blank">http://frozen-falls-98471.herokuapp.com/ports/database/</a> should not be exposed. What is it intended to do anyway?</div><div><br></div><div>3. installation statistics:</div><div><br></div><div>a) Last year we had a quick attempt at this project (installation statistics part). It's still lying in my account. Probably the only part where we spent some time was models.py [2]. You could review it sometime soon and come back with doubts/suggestions. It almost has the model implementation on the installed ports statistics with a sample submission data file present at the root of the project. Class Port, Category, etc can help with the first part of the project as well.</div><div><br></div><div><div>The tricky part was to figure out (still needs to be figured out) unique ports and what to keep as the primary key. Similarly, in the case of maintainers (and look for more such cases).</div><br class="m_978905767886022098gmail-Apple-interchange-newline"></div><div>There are several variations of how maintainers are mentioned in the Portfiles, example GitHub handles, or emails, or personal websites at times. You may want to look into the different formats (or ask on the list separately), and come up with a solution to parse and store.</div><div><br></div><div>b) I would suggest keeping all the parsing scripts together at some place in your project. Keep a document where you have changed the parsing output (before and after) and also, what do they parse. Naming a script parse.py doesn't tell much. I am having difficulty tracking down and reviewing all the scripts.</div><div><br></div><div><br></div><div>==</div><div><br></div><div>As Mojca said, I am not seeing any way to provide code review on Github when it's already merged. Since you have the base application ready, it's time to use PRs. I would also advise starting to follow at least some of the PEP8 style guide conventions, it's good to follow clean code practices from the beginning. You can either use coala lint or pylint before pushing the code, if familiar.</div><div><br></div><div>You recently added a .gitignore file but there are .pyc, __pycache__/, etc files from before. Consider cleaning them up.</div><div><br></div><div>These are all the suggestions for later, but only a small portion of what a proposal is expected to include. Right now, I'd suggest working on the parsing the maintainers as best as possible. It'd then be good to tackle the project part by part.</div><div><br></div><div>[1]: <a href="https://github.com/umeshksingla/macports-stats/blob/master/firstproject/firstapp/models.py" target="_blank">https://github.com/umeshksingla/macports-stats/blob/master/firstproject/firstapp/models.py</a></div><div><br></div><div>Best,</div><div>Umesh</div></div></div></div></div></div></div></div></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Mar 21, 2019 at 3:57 PM Arjun Salyan <<a href="mailto:arjun.salyan.che17@itbhu.ac.in" target="_blank">arjun.salyan.che17@itbhu.ac.in</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr">On Thu, Mar 21, 2019 at 10:20 AM Mojca Miklavec <<a href="mailto:mojca@macports.org" target="_blank">mojca@macports.org</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">(2) You made a simple PR last time to fix portindex2json for a more<br>
reasonable output of categories. Would you be willing for a tiny bit<br>
more difficult task and try to improve the output for maintainers as<br>
well? We would want a list of all maintainers with two optional keys<br>
for each (email & github handle) plus a boolean value to tell whether<br>
the port is under openmaintainer policy.<br></blockquote><div> </div><div>Hi, I was working on this. What do I do with "nomaintainer" ? For now I am getting the following output.</div><div><br></div><div><p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">{</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"> "variants" : "clang33 clang34 clang37 clang38 clang39 clang40 clang50 clang60 clang70 mpich mpich_devel openmpi openmpi_devel python26 python27 python33 python34 python35 python36 python37 debug no_static no_single regex_match_extra universal",</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"> "subports" : "boost-numpy",</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"> "portdir" : "devel\/boost",</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"> "description" : "Collection of portable C++ source libraries",</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"> "homepage" : "http:\/\/<a href="http://www.boost.org" target="_blank">www.boost.org</a>",</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"> "epoch" : "0",</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"> "platforms" : "darwin",</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"> "name" : "boost",</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"> "depends_lib" : "port:zlib port:expat port:bzip2 port:libiconv port:icu port:python27",</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo"><span style="font-variant-ligatures:no-common-ligatures"><font color="#000000"> <b> </b></font><font color="#b45f06"><b>"openmaintainer" : True,</b></font></span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"> "long_description" : "Boost provides free portable peer-reviewed C++ libraries. The emphasis is on portable libraries which work well with the C++ Standard Library.",</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"> "license" : "Boost-1",</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo"><span style="font-variant-ligatures:no-common-ligatures"><font color="#000000"> </font><font color="#b45f06"><b>"maintainers" : [{</b></font></span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo"><span style="font-variant-ligatures:no-common-ligatures"><font color="#b45f06"><b> "github" : "<a href="https://www.github.com/ryandesign" target="_blank">https://www.github.com/ryandesign</a>"</b></font></span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo"><span style="font-variant-ligatures:no-common-ligatures"><font color="#b45f06"><b> },{</b></font></span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo"><span style="font-variant-ligatures:no-common-ligatures"><font color="#b45f06"><b> "github" : "<a href="https://www.github.com/michaelld" target="_blank">https://www.github.com/michaelld</a>"</b></font></span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo"><span style="font-variant-ligatures:no-common-ligatures"><font color="#b45f06"><b> }],</b></font></span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"> "categories" : [devel],</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"> "version" : "1.66.0",</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"> "revision" : "3"</span></p>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">}</span></p></div></div></div></div></div>
</blockquote></div>