<div dir="ltr">Hey,<br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Apr 1, 2019 at 8:08 PM Renee Otten <<a href="mailto:ottenr.work@gmail.com">ottenr.work@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">hi Karan, Mojca, Cyril, <br>
<br>
<br>
I am happy to help with testing and provide feedback. I quickly glanced over the proposal draft and agree with what Cyril said; in addition, there is a figure showing a WebUI that is not described (personally I am not sure if that would be needed anyway). <br>
<br></blockquote><div>I have removed the webUI from the proposal now. </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I agree that the most important thing is to (i) make the most accurate and syntactically correct Portfiles and (ii) provide an update mechanism. See below for a few consideration with respect to the MacPorts backend for PyPI, but some might apply to other backends as well.<br>
<br>
1) while generating the dependency list, please keep in mind that not all Python ports follow the PyPI naming scheme (with respect to capitalization amongst others). For example the same package is called “py-codestyle” in MacPorts, but “pycodestyle” on PyPI. We probably should follow the PyPI naming scheme in the long run, but in cases like this you wouldn’t want to (recursively) create a “pycodestyle” package that effectively duplicates a port.<br></blockquote><div> </div><div>Is it possible to rename the existing Python ports as per PYPI so that issues of duplicates ports can be avoided?</div><div>If renaming is not possible and if there's a pattern like “py-codestyle” in MacPorts, but “pycodestyle” on PyPI then we can query for both combination to see if the port exists or not and then decide accordingly, though this would be slower and practically double the number of queries but just a possible solution.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
2) testing whether dependencies are present already in MacPorts could be done using “port lint”. If the idea is to use that, it would probably be good to extend the functionality of “port lint” to automatically do the linting on sub-ports as well (instead of needing to call it on every sub-port again).<br></blockquote><div> </div><div>I used port lint today for the first time and still not sure what exactly it does so first I will understand it.</div><div>As far as I understood port lint check for any syntax error in the ports</div><div>I guess it would be great to add the auto sub port linting feature.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
3) if there are version requirements specified for dependencies it would be great to check whether these are met, in addition to just checking whether a port for that package is present<br></blockquote><div> </div><div>I guess that would be the plan. </div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
4) ideally the “python_requires” information should be used to only add the supported versions that are present in the default “python.versions” field<br></blockquote><div> </div><div>Yeah sorry as of now I had kept it static, it would be dynamic in future and will only have supported versions. </div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
5) there is no need to add the “md5” checksum<br></blockquote><div> </div><div>Ok </div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
As Cyril said, updating existing packages should be implemented only once after considering the best option. I would imagine that the only things the “update” function should touch in an existing portfile are “version, revision, checksums, depends_build, depends_lib, depends_run”. All other lines in the existing portfile should stay the same and care has to be taken to minimize formatting changes as not to pollute the diff. The easiest way (in my mind) is just to use the “upt package” command to generate a “new" portfile for the package, parse the existing portfile and only swap the above-mentioned fields for the newly generated ones.<br></blockquote><div> </div><div>I agree on this and have updated the proposal accordingly. </div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Again, these are just some initial thoughts and I will take a closer look at upt and the work you have done so far. I hope this helps and let me know if you have any questions. <br>
<br>
Best,<br>
Renee<br><br></blockquote><div><br></div><div>Thanks very much for review.</div><div>Is there any other goals or tasks that can be taken under this project?</div><div><br></div><div>Thanks,</div><div>Karan Sheth</div><div><br></div></div></div>
<br>
<div><img src="http://somaiya.edu/media/images/top-layer_footer.jpg" style="font-size:1.3em"></div><div><a href="https://www.somaiya.edu" style="font-size:1.3em" target="_blank"><img src="http://somaiya.edu/media/images/svv-logo-email-footer.jpg"></a><span style="font-size:1.3em"> </span><a href="http://www.somaiya-ayurvihar.org" style="font-size:1.3em" target="_blank"><img src="http://somaiya.edu/media/images/Medical-Logo-email-footer.jpg"></a><span style="font-size:1.3em"> </span><a href="http://nareshwadi.org" style="font-size:1.3em" target="_blank"><img src="http://somaiya.edu/media/images/Nareshwadi-Logo-email-footer.jpg"></a><span style="font-size:1.3em"> </span><a href="http://somaiya.com" style="font-size:1.3em" target="_blank"><img src="http://somaiya.edu/media/images/Somaiya-Trust-Logo-email-footer.jpg"></a><span style="font-size:1.3em"> </span><a href="http://www.helpachild.in" style="font-size:1.3em" target="_blank"><img src="http://somaiya.edu/media/images/HelpAChild-Logo-email-footer.jpg"></a><span style="font-size:1.3em"> </span><a href="http://nareshwadi.org" style="font-size:1.3em" target="_blank"><img src="http://somaiya.edu/media/images/PragatiMandal-Logo-email-footer-1.jpg"></a></div>