<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi,<div class=""><br class=""></div><div class="">I would definitely say the many small PR approach is preferred to a single massive one with many many changes. A big PR like that is not going to help get it reviewed quicker. Mixing up new ports, with port updates, in one PR would really be a bit of a mess, I would say.</div><div class=""><br class=""></div><div class="">So yes, please try and submit each update separately. Once you have all the bits in place you ca then submit Blender update itself.</div><div class=""><br class=""></div><div class="">Chris</div><div class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 12 May 2020, at 6:59 pm, Ruben Di Battista <<a href="mailto:rubendibattista@gmail.com" class="">rubendibattista@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div style="font-family: Merriweather, Arial; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none; color: rgb(51, 51, 51);" class="">I think the best approach is to isolate “atomic” changes, and open a PR for each of them. This way problems with dependencies can be isolated and decoupled from those for Blender. </div><div style="font-family: Merriweather, Arial; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none; color: rgb(51, 51, 51);" class=""><br class=""></div><div style="font-family: Merriweather, Arial; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none; color: rgb(51, 51, 51);" class="">If they are really too many, maybe try to provide PRs for semantically related libraries or somehow related in some other way (like, “python” dependencies). I would say a maximum of 3 - 4 ports per PR? </div><div style="font-family: Merriweather, Arial; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none; color: rgb(51, 51, 51);" class=""><br class=""></div><div style="font-family: Merriweather, Arial; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none; color: rgb(51, 51, 51);" class="">I’ll leave the word to more expert members of the community, that’s my general approach when I need to merge upstream complex trees of ports...</div><br style="caret-color: rgb(0, 0, 0); font-family: Merriweather, Arial; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><div class="gmail_signature" style="caret-color: rgb(0, 0, 0); font-family: Merriweather, Arial; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><pre class=""><code class=""> _
-. .´ |∞∞∞∞
', ; |∞∞∞∞∞∞
˜˜ |∞∞∞∞∞∞∞∞∞ RdB
,., |∞∞∞∞∞∞
.' '. |∞∞∞∞
-' `’
<a href="https://rdb.is/" class="">https://rdb.is</a>
</code></pre></div><br style="caret-color: rgb(0, 0, 0); font-family: Merriweather, Arial; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><p class="airmail_on" style="caret-color: rgb(0, 0, 0); font-family: Merriweather, Arial; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;">On 12 May 2020 at 19:45:30, Jason Liu (<a href="mailto:jasonliu@umich.edu" class="">jasonliu@umich.edu</a>) wrote:</p><blockquote type="cite" class="clean_bq" style="font-family: Merriweather, Arial; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;"><span class=""><div class=""><div class=""></div><div class=""><div dir="ltr" class=""><div class="">I would like to contribute a portfile for the newest version of Blender. I already have a local portfile that is compiling successfully, and I am doing some cleanup before submitting a pull request on GitHub. In addition to Blender itself, I have also packaged several of Blender's dependent libraries, which would also be new ports. My question is: Would it be better for me to submit all of the portfiles for Blender and the libraries in one single pull request? Or should I submit one pull request for each new package individually?</div><div class=""><br class=""></div><div class="">The reason why I ask is that the dependency tree is a bit complex, with some of the libraries dependent on other libraries which I packaged as well. And if I were to submit each of the libraries individually, there's no telling how long it would take to get each one of them accepted and merged before I would be able to submit the Blender portfile.</div><div class=""><br clear="all" class=""><div class=""><div dir="ltr" data-smartmail="gmail_signature" class=""><div dir="ltr" class=""><div class="">-- </div><div class="">Jason Liu</div></div></div></div></div></div></div></div></span></blockquote></div></blockquote></div><br class=""></div></body></html>