<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div></div><div><br></div><div><br>On Jul 5, 2020, at 02:24, Chris Jones <<a href="mailto:jonesc@hep.phy.cam.ac.uk">jonesc@hep.phy.cam.ac.uk</a>> wrote:<br><br></div><blockquote type="cite"><div><meta http-equiv="content-type" content="text/html; charset=utf-8"><div dir="ltr">Hi,</div><div dir="ltr"><br></div><div dir="ltr">Your optional patch looks on a quick scan ok to me.</div></div></blockquote><div><br></div><div>I hope so. I think someone like Ionic might easily do better. It should throw std::exception but I had trouble with that. Older versions of this threw std::logic_error and that was simpler to get working. It seems to work.</div><div><br></div><br><blockquote type="cite"><div><div dir="ltr"> To be clear, you are proposing adding this to the llvm ports, to patch the version of the headers installed by that, right ?</div></div></blockquote><div><br></div><div>yes. In the somewhat custom way we build the toolchain on MP, we copy the libc++ headers from the matching libcxx version and have that clang use those headers with the system libc++.I guess because Apple tests libc++ capability when using the headers, that does work. <<span style="background-color: rgba(255, 255, 255, 0);"><a href="https://github.com/macports/macports-ports/blob/76973121d7f85a25c850223b7736ced12f5c5aa5/lang/llvm-9.0/Portfile#L580">https://github.com/macports/macports-ports/blob/76973121d7f85a25c850223b7736ced12f5c5aa5/lang/llvm-9.0/Portfile#L580</a>></span></div><div><br></div><br><blockquote type="cite"><div><div dir="ltr"><br></div><div dir="ltr">Chris</div><div dir="ltr"><br><blockquote type="cite">On 5 Jul 2020, at 6:33 am, Ken Cunningham <<a href="mailto:ken.cunningham.webuse@gmail.com">ken.cunningham.webuse@gmail.com</a>> wrote:<br><br></blockquote></div><blockquote type="cite"><div dir="ltr"><meta http-equiv="Content-Type" content="text/html; charset=utf-8">As software using c++17 is upon us, we have a slight problem with std::optional.<div class=""><br class=""></div><div class="">clang has supported std::optional for some time, and clang-9.0, at least, appears to support std::optional right back to the ancient systems.</div><div class=""><br class=""></div><div class="">however, there is one small part of std::optional, std::optional::value, that needs a callback function in case of an exception being thrown, called “bad_optional_access”. That symbol is compiled into libc++.dylib as of 10.13.</div><div class=""><br class=""></div><div class="">So clang-9.0 supports 99% of std::optional all the way back, but that bad_optional_access function limits that one part of it, std::optional::value, to 10.13. </div><div class=""><br class=""></div><div class="">There are availability tests build into the libc++ headers based on system version to turn that off.</div><div class=""><br class=""></div><div class="">However, on 10.6, where I build and install libc++ 5.0, that symbol exists in libc++.dylib, so I disable clang’s availability tests.</div><div class=""><br class=""></div><div class="">It is quite simple (I think) to inline a function implementing bad_optional_access into the <optional> header. That could be used for 10.7 to 10.12, and then all those systems could comfortably implement c++17, and no problem. Otherwise we have to install a newer libc++.dylib on older systems, which is a simple but big problem, as it were.</div><div class=""><br class=""></div><div class="">Here’s the <optional> patch. I only speak basic c++, so improve this if you can.</div><div class=""><br class=""></div><div class="">So I am proposing to use this patch, and disable Apple’s availability test in <__config> for bad_optional_access.</div><div class=""><br class=""></div><div class="">Then all systems from 10.5 to current can use c++17 std::optional, and disaster averted until the next crisis.</div><div class=""><br class=""></div><div class="">Warts?</div><div class=""><br class=""></div><div class="">Ken</div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><optional> patch:</div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><pre style="box-sizing: border-box; font-family: SFMono-Regular, Consolas, "Liberation Mono", Menlo, monospace; font-size: 11.899999618530273px; margin-top: 0px; margin-bottom: 16px; word-wrap: normal; padding: 16px; overflow: auto; line-height: 1.45; background-color: rgb(246, 248, 250); border-top-left-radius: 6px; border-top-right-radius: 6px; border-bottom-right-radius: 6px; border-bottom-left-radius: 6px; caret-color: rgb(36, 41, 46); color: rgb(36, 41, 46);" class=""><code style="box-sizing: border-box; font-family: SFMono-Regular, Consolas, "Liberation Mono", Menlo, monospace; padding: 0px; margin: 0px; border-top-left-radius: 6px; border-top-right-radius: 6px; border-bottom-right-radius: 6px; border-bottom-left-radius: 6px; word-break: normal; border: 0px; display: inline; overflow: visible; line-height: inherit; word-wrap: normal;" class="">$ diff -u optional.orig optional
--- optional.orig 2020-07-04 18:51:05.000000000 -0700
+++ optional 2020-07-04 18:51:13.000000000 -0700
@@ -168,13 +168,10 @@
namespace std // purposefully not using versioning namespace
{
-class _LIBCPP_EXCEPTION_ABI _LIBCPP_AVAILABILITY_BAD_OPTIONAL_ACCESS bad_optional_access
- : public exception
-{
+// 20.5.8, class bad_optional_access
+class bad_optional_access : public logic_error {
public:
- // Get the key function ~bad_optional_access() into the dylib
- virtual ~bad_optional_access() _NOEXCEPT;
- virtual const char* what() const _NOEXCEPT;
+ explicit bad_optional_access() : logic_error{"bad optional access"} {}
};
} // std</code></pre><div class=""><br class=""></div></div></div></blockquote></div></blockquote></body></html>