<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div><blockquote type="cite" class=""><div class="">On Aug 29, 2021, at 8:02 AM, Frank Dean <<a href="mailto:frank@fdsd.co.uk" class="">frank@fdsd.co.uk</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">I have a few questions to ask in relation to a series of Portfiles that<br class="">I have created to support installing and running a map tile server for<br class="">OpenStreetMaps [1].<br class=""><br class="">[1]: <a href="https://switch2osm.org/serving-tiles/" class="">https://switch2osm.org/serving-tiles/</a><br class=""><br class="">The logical Portfiles:<br class=""><br class="">- libprotozero - library required by libosmium<br class=""><br class=""> <a href="https://github.com/mapbox/protozero" class="">https://github.com/mapbox/protozero</a><br class=""><br class="">- libosmium - library required by osmium-tool<br class=""><br class=""> <a href="https://github.com/osmcode/libosmium" class="">https://github.com/osmcode/libosmium</a><br class=""><br class="">- osmium-tool - application required at runtime by mod_tile/renderd<br class=""><br class=""> <a href="https://github.com/osmcode/osmium-tool" class="">https://github.com/osmcode/osmium-tool</a><br class=""><br class="">- osmosis - Java application required at runtime by mod_tile/renderd<br class=""><br class=""> <a href="https://github.com/openstreetmap/osmosis" class="">https://github.com/openstreetmap/osmosis</a><br class=""><br class="">- openstreetmap-carto - style sheets used by mod_tile/renderd<br class=""><br class=""> <a href="https://github.com/gravitystorm/openstreetmap-carto" class="">https://github.com/gravitystorm/openstreetmap-carto</a><br class=""><br class="">- mod_tile/renderd - the OpenStreetMaps tile server<br class=""><br class=""> <a href="https://wiki.openstreetmap.org/wiki/Mod_tile" class="">https://wiki.openstreetmap.org/wiki/Mod_tile</a><br class=""><br class="">1. Should I submit each Portfile in dependency order and await its<br class=""> acceptance before submitting the next in sequence, or submit them<br class=""> in dependency related batches in a single pull request?<br class=""><br class="">2. The primary port is 'mod_tile' which contains an Apache module for<br class=""> serving the tiles and a 'renderd' daemon that renders and creates<br class=""> tile images based on requests from 'mod_tile'. Both artefacts are<br class=""> created in a single build.<br class=""><br class=""> I have currently named the port 'renderd', but the project is<br class=""> commonly known as 'mod_tile'. Naming the port 'renderd' was the<br class=""> only way I could succeed in the 'renderd' startup item being loaded<br class=""> via the 'sudo port load ${subport}' command.<br class=""><br class=""> Is there a better way of naming and creating this port, perhaps as<br class=""> subports?<br class=""><br class="">3. Getting the tile server up and running requires quite a number of<br class=""> steps. I have created a shell script to largely automate the<br class=""> process. At runtime it uses scripts from both 'openstreetmap-carto'<br class=""> and 'mod_tile/renderd', so doesn't immediately sit comfortably being<br class=""> installed with either of them.<br class=""><br class=""> Is it best to create a simple separate standalone port (without an<br class=""> upstream project), containing just the shell script, naming it<br class=""> something like 'osm-tile-server' and depending on the other two<br class=""> ports; or simply include it in one of the other ports with runtime<br class=""> checks for the existence of required executables with helpful error<br class=""> messages when they're absent?<br class=""><br class="">Many thanks,<br class=""><br class="">Frank<br class=""></div></div></blockquote></div><br class=""><div class="">I’ll offer my thoughts to get the ball rolling. First, from briefly looking over the involved projects, this is a relatively complex set of ports so be prepared that it may take some time to get everything working properly. Good on you for tackling this!</div><div class=""><br class=""></div><div class="">Do you have some support upstream? AFAICT, mod_tile seems to pretty much only on Debian at this point. </div><div class=""><br class=""></div><div class="">Re your questions:</div><div class=""><br class=""></div><div class="">1) I think you should add the ports in dependency order rather than one submission including everything. These days, pull requests tend to get acted on more quickly than tickets. If you haven’t seen it, we have a wiki page about MacPorts and git at:</div><div class=""><br class=""></div><div class=""><a href="https://trac.macports.org/wiki/WorkingWithGit#CommongittaskswhileworkingwithMacPortsbase" class="">https://trac.macports.org/wiki/WorkingWithGit</a></div><div class=""><br class=""></div><div class="">You can submit multiple pull requests at once. Just add links to the other related PRs so anyone reviewing will know that there is a series.</div><div class=""><br class=""></div><div class="">2) I see that the GitHub project is named “mod_tile” while Debian has called their package "libapache2-mod-tile”. MacPorts has several ports named mod_foo so I think mod_tile makes the most sense.</div><div class=""><br class=""></div><div class=""><a href="https://ports.macports.org/search/?installed_file=&q=mod_&name=on" class="">https://ports.macports.org/search/?installed_file=&q=mod_&name=on</a></div><div class=""><br class=""></div><div class="">Re the startup item, I think you should be able to use the startupitem.name and startup item.executable keywords to make the renderd daemon work as required. No?</div><div class=""><br class=""></div><div class=""><a href="https://guide.macports.org/#reference.startupitems" class="">https://guide.macports.org/#reference.startupitems</a></div><div class=""><br class=""></div><div class="">3) Without seeing the shell script you’ve developed, it is difficult to say whether you should add it to the mod_tile port or port it in a standalone port. I would lean towards including it in mod_tile. Perhaps you could submit it upstream for inclusion in a future release?</div><div class=""><br class=""></div><div class="">Hope this helps,</div><div class=""><br class=""></div><div class="">Craig</div></body></html>