[MacPorts] #38485: rethinkdb: add new package
MacPorts
noreply at macports.org
Fri Mar 22 03:19:33 PDT 2013
#38485: rethinkdb: add new package
-------------------------------+--------------------------
Reporter: anatol.pomozov@… | Owner: ryandesign@…
Type: submission | Status: closed
Priority: Normal | Milestone:
Component: ports | Version:
Resolution: fixed | Keywords:
Port: rethinkdb |
-------------------------------+--------------------------
Changes (by ryandesign@…):
* status: assigned => closed
* resolution: => fixed
Comment:
I have committed your port in r104261 with these changes
* changed tabs to spaces and removed trailing whitespace
* changed the maintainers line to nomaintainer (unless you want to
maintain this port?)
* removed the lines "distname rethinkdb-${version}", "use_configure yes"
and "worksrcdir rethinkdb-${version}" because those are the defaults
* allowed nodejs-devel to satisfy the nodejs dependency
* changed creation of empty ${destroot}${prefix}/var/lib/rethinkdb/
directory into a destroot.keepdirs invocation, which I assume is what you
wanted, because otherwise MacPorts deletes empty directories after the
destroot phase
* removed comment "correct permissions for files?" and changed xinstall
invocations to not set the execute bit on files that don't need it
* made a variable for ${prefix}/share/rethinkdb/web and used it
throughout
* modified the livecheck slightly
* reordered some lines
* disabled universal variant and indicated support only for i386 and
x86_64 architectures, to match nodejs
* shortened the description
1.4.1 is out already. Should we update?
I did not add a startup script. On OS X, we would use a launchd plist,
which in MacPorts is created using using the
[http://guide.macports.org/chunked/reference.startupitems.html startupitem
keywords]. Feel free to open a new ticket with a patch to add that.
I noticed that rethinkdb only actually links with libv8 and libprotobuf;
do we know more about how rethinkdb uses boost, nodejs and coffee-script?
Maybe they need to be a different dependency type instead of depends_lib.
--
Ticket URL: <https://trac.macports.org/ticket/38485#comment:3>
MacPorts <http://www.macports.org/>
Ports system for OS X
More information about the macports-tickets
mailing list