[MacPorts] #55764: geoexpress-sdk @9.0.0.3864: upgrade to 9.5.4.4709

[MacPorts]

#55764: geoexpress-sdk @9.0.0.3864: upgrade to 9.5.4.4709
-----------------------------+----------------------
  Reporter:  ForTozs         |      Owner:  (none)
      Type:  update          |     Status:  new
  Priority:  Normal          |  Milestone:
 Component:  ports           |    Version:  2.4.2
Resolution:                  |   Keywords:  haspatch
      Port:  geoexpress-sdk  |
-----------------------------+----------------------
Changes (by ryandesign):

 * cc: ryandesign (added)


Comment:

 Replying to [comment:1 ForTozs]:
 > The `install_name_tool --rpath` commands don't have permission to
 execute. Anyone know how to fix this?

 Remove these three lines you added in the destroot phase:

 {{{
         system "install_name_tool -add_rpath
 "/opt/local/share/Geo_DSDK/Raster_DSDK/lib/"
 /opt/local/share/Geo_DSDK/Raster_DSDK/lib/libtbb.dylib"
         system "install_name_tool -add_rpath
 "/opt/local/share/Geo_DSDK/Raster_DSDK/lib/"
 /opt/local/share/Geo_DSDK/Raster_DSDK/lib/libltidsdk.dylib"
         system "install_name_tool -add_rpath
 "/opt/local/share/Geo_DSDK/Raster_DSDK/lib/"
 /opt/local/lib/libgdal.20.dylib"
 }}}

 In the destroot phase, you are not allowed to modify files that are
 located outside of the `${destroot}` directory. It would also be
 inappropriate for the geoexpress-sdk port to modify the file
 /opt/local/lib/libgdal.20.dylib since that file is not provided by this
 port (it's provided by the gdal port; the gdal port should make any
 necessary adjustments to that file, but if geoexpress-sdk installs itself
 correctly, no adjustments should be needed).

 In addition, it is incorrect to hardcode `/opt/local`. The variable
 `${prefix}` should be used instead.

 Instead of using rpath, I would just fix the library's id to be absolute,
 like almost all other libraries in MacPorts. See #56526.

 I assume that switching to a binary with "darwin16" in the name will make
 this port require Darwin 16 (i.e. macOS Sierra) or later. Currently the
 port uses a binary with "darwin12" in the name, supporting Darwin 12 (OS X
 Mountain Lion) or later; that covers a much larger portion of the MacPorts
 user base.

-- 
Ticket URL: <https://trac.macports.org/ticket/55764#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS