[MacPorts] #58309: NOP port upgrade outdated returns error status

[MacPorts]

#58309: NOP port upgrade outdated returns error status
------------------------+-------------------------------------------------
  Reporter:  fhgwright  |      Owner:  Kurt Hindenburg <kurt.hindenburg@…>
      Type:  defect     |     Status:  closed
  Priority:  Normal     |  Milestone:
 Component:  base       |    Version:  2.5.4
Resolution:  fixed      |   Keywords:
      Port:             |
------------------------+-------------------------------------------------

Comment (by fhgwright):

 That looks like this change should fix the immediate problem, although the
 earlier "fix" was pretty ugly.  The code for getting the port list is
 directly treating the empty result as an error, except for a special-case
 check for whether it was called from "upgrade".  It would be far cleaner
 if it simply returned the result without complaining. leaving it up to the
 caller to decide whether an empty list is acceptable.  If that would
 require fixing too many places to call out the error, then there could be
 a wrapper function with the fail-on-empty check, with "upgrade" not using
 the wrapper.

-- 
Ticket URL: <https://trac.macports.org/ticket/58309#comment:4>
MacPorts <https://www.macports.org/>
Ports system for macOS