[MacPorts] #59927: bison @3.5 does not build with older gcc versions (gcc-4.2 and similar) because "#pragma GCC diagnostic not allowed inside functions"

[MacPorts]

#59927: bison @3.5 does not build with older gcc versions (gcc-4.2 and similar)
because "#pragma GCC diagnostic not allowed inside functions"
------------------------+--------------------
  Reporter:  ballapete  |      Owner:  kencu
      Type:  defect     |     Status:  closed
  Priority:  Normal     |  Milestone:
 Component:  ports      |    Version:  2.6.2
Resolution:  fixed      |   Keywords:
      Port:  bison      |
------------------------+--------------------

Comment (by akimd):

 Hi Ken,

 Replying to [comment:17 kencu]:
 > Well, that's nice to hear.
 >
 > Honest truth is not many upstream projects are too interested in
 tweaking builds for compilers like gcc-4.2 any more, and working around
 things missing from the MacOSX Tiger headers even less, so we are fairly
 used to doing a little surgery on these ports for our rather dedicated
 legacy system user base.

 Ok, I see.  Out of curiosity: how long do you plan on keeping these
 platforms updated?

 I'm using Travis for the CI, and unfortunately I don't think I can run GCC
 4.2 over there, the oldest we have currently is 4.6 (see https://travis-
 ci.org/github/akimd/bison/builds/669995270 for instance).

 > redefining typedefs was introduced in some compiler version > gcc-4.2 --
 I don't recall just when it occurred --

 Yep, it's C11, rejected in C99.

 I took care of two issues:
 - the pragmas for diagnostics
 - the double typedef

 So it is my understanding that in this case the C11 compiler is no longer
 needed, and as a consequence the __WORDSIZE hack is no longer needed
 either, right?  Do you have means to check a tarball?  If you can, please
 give a shot at this one:

 https://www.lrde.epita.fr/~akim/private/bison/bison-3.5.3.3-6e89b.tar.gz
 https://www.lrde.epita.fr/~akim/private/bison/bison-3.5.3.3-6e89b.tar.xz

 I'll release it once I know it addresses your concerns.

 Cheers!

-- 
Ticket URL: <https://trac.macports.org/ticket/59927#comment:18>
MacPorts <https://www.macports.org/>
Ports system for macOS