[MacPorts] #60404: rust: use copy, not system cp -r

MacPorts noreply at macports.org
Mon Apr 27 08:07:32 UTC 2020


#60404: rust: use copy, not system cp -r
------------------------+----------------------
 Reporter:  ryandesign  |      Owner:  g5pw
     Type:  defect      |     Status:  assigned
 Priority:  Normal      |  Milestone:
Component:  ports       |    Version:  2.6.2
 Keywords:              |       Port:  rust
------------------------+----------------------
 The rust portfile uses `system` on several occasions to call `cp -r`. Why
 does it do this, rather than use the Tcl `copy` procedure possibly in
 combination with `glob` and the expansion operator (`{*}`)? For example,
 instead of:

 {{{
 system "cp -r ${workpath}/rustc-${rustc_version}-${rust_platform}/rustc/*
 ${rust_root}"
 }}}

 Why not (untested):

 {{{
 copy {*}[glob ${workpath}/rustc-${rustc_version}-${rust_platform}/rustc/*]
 ${rust_root}
 }}}

-- 
Ticket URL: <https://trac.macports.org/ticket/60404>
MacPorts <https://www.macports.org/>
Ports system for macOS


More information about the macports-tickets mailing list