[MacPorts] #68841: Invalid add_users command in Portfile

MacPorts noreply at macports.org
Tue Dec 5 19:55:22 UTC 2023


#68841: Invalid add_users command in Portfile
-------------------------+--------------------
  Reporter:  pcafstockf  |      Owner:  (none)
      Type:  defect      |     Status:  new
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:
Resolution:              |   Keywords:
      Port:  dovecot     |
-------------------------+--------------------
Description changed by pcafstockf:

Old description:

> Dovecot port attempts to add two user accounts (_dovecot and _dovenull).
> Portfiles support adding multiple accounts, but it needs to be done using
> a single add_users command.\\
>
> As currently written, only the _dovenull account ends up actually being
> created.\\
>
> Instead of:
> {{{
> add_users ${default_internal_user} group=${default_internal_user}
> realname=Dovecot
> add_users ${default_login_user}    group=${default_login_user}
> realname=Dovenull
> }}}
> The Profile needs to be:\\
> {{{
> add_users ${default_internal_user} group=${default_internal_user}
> realname=Dovecot ${default_login_user}    group=${default_login_user}
> realname=Dovenull
> }}}
> Or for readability maybe:\\
> {{{
> add_users \
>     ${default_internal_user} group=${default_internal_user}
> realname=Dovecot \
>     ${default_login_user}    group=${default_login_user}
> realname=Dovenull
> }}}
> Note the line continuation chars

New description:

 Dovecot port attempts to add two user accounts (_dovecot and _dovenull).
 Portfiles support adding multiple accounts, but it needs to be done using
 a single add_users command.\\

 As currently written, only the _dovenull account ends up actually being
 created.\\

 Instead of:
 {{{
 add_users ${default_internal_user} group=${default_internal_user}
 realname=Dovecot
 add_users ${default_login_user}    group=${default_login_user}
 realname=Dovenull
 }}}
 The Profile needs to be:\\
 {{{
 add_users ${default_internal_user} group=${default_internal_user}
 realname=Dovecot ${default_login_user}    group=${default_login_user}
 realname=Dovenull
 }}}
 Or for readability maybe:\\
 {{{
 add_users \
     ${default_internal_user} group=${default_internal_user}
 realname=Dovecot \
     ${default_login_user}    group=${default_login_user}
 realname=Dovenull
 }}}
 Note the line continuation chars.

 Forgot to add a link to the add_users documentation
 (https://guide.macports.org/#reference.keywords)

--

-- 
Ticket URL: <https://trac.macports.org/ticket/68841#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS


More information about the macports-tickets mailing list