[MacPorts] #65896: emacs fails to compile on old Mac <= 10.7

[MacPorts]

#65896: emacs fails to compile on old Mac <= 10.7
-----------------------+--------------------------------------------
  Reporter:  rmottola  |      Owner:  drkp
      Type:  defect    |     Status:  assigned
  Priority:  Normal    |  Milestone:
 Component:  ports     |    Version:
Resolution:            |   Keywords:  tiger leopard snowleopard lion
      Port:  emacs     |
-----------------------+--------------------------------------------
Changes (by ryandesign):

 * keywords:  gtk lion => tiger leopard snowleopard lion
 * cc: catap (added)


Old description:

> Emacs fails to compile on 10.7 because of this error:
>

> {{{
> :info:build nsterm.m:8391:8: error: use of undeclared identifier 'child'
> :info:build   if ([child
> respondsToSelector:@selector(setAccessibilitySubrole:)])
> :info:build        ^
>
> }}}
>
> The code looks for a non existing ivar, checking source code, emacs fixed
> it with this commit:
>
> https://github.com/emacs-
> mirror/emacs/commit/96ec2ac7d0bdb6b1193217b35f7d74d79b7c2033
>
> we might have a backport patch for it. It does not apply cleanly, but it
> contains the fix for that part.
>
> Another build issue remains:
>
> {{{
> nsmenu.m:644:48: error: use of undeclared identifier
> 'NSTextAlignmentRight'
>     [[[NSTextTab alloc] initWithTextAlignment: NSTextAlignmentRight
>
> }}}
>

> And here I am at loss,
> {{{
> NSTextAlignmentRight
> }}}
>  is valid, not something recent, what else is missing?

New description:

 Emacs fails to compile on 10.7 because of this error:

 {{{
 :info:build nsterm.m:8391:8: error: use of undeclared identifier 'child'
 :info:build   if ([child
 respondsToSelector:@selector(setAccessibilitySubrole:)])
 :info:build        ^
 }}}

 The code looks for a non existing ivar, checking source code, emacs fixed
 it with this commit:

 https://github.com/emacs-
 mirror/emacs/commit/96ec2ac7d0bdb6b1193217b35f7d74d79b7c2033

 we might have a backport patch for it. It does not apply cleanly, but it
 contains the fix for that part.

 Another build issue remains:

 {{{
 nsmenu.m:644:48: error: use of undeclared identifier
 'NSTextAlignmentRight'
     [[[NSTextTab alloc] initWithTextAlignment: NSTextAlignmentRight
 }}}


 And here I am at loss,
 {{{
 NSTextAlignmentRight
 }}}
 is valid, not something recent, what else is missing?

--

Comment:

 You didn't attach a main.log file or tell us what version of emacs you
 were using.

 The commit you mentioned appears to contain fixes for both issues you
 reported and was included in emacs 29.1 which is the version in MacPorts
 now so please retry with that version.

-- 
Ticket URL: <https://trac.macports.org/ticket/65896#comment:4>
MacPorts <https://www.macports.org/>
Ports system for macOS