[MacPorts] #68449: java portgroup: Unintelligible comments

MacPorts noreply at macports.org
Fri Oct 13 12:29:06 UTC 2023


#68449: java portgroup: Unintelligible comments
-------------------------+--------------------
  Reporter:  ryandesign  |      Owner:  (none)
      Type:  defect      |     Status:  new
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:
Resolution:              |   Keywords:
      Port:  java        |
-------------------------+--------------------

Comment (by chrstphrchvz):

 This was [https://github.com/macports/macports-ports/pull/20051]

 My guess is that the comment meant to say that if a port’s build outputs
 have hardcoded filepaths from the `java.fallback` port, then set
 `java.enforce` for the port to always depend on `java.fallback`,
 regardless of whether Java already present on the system.

 If I understand the intention of this option correctly, then I do not see
 how it is desirable, and I am in favor of removing it. I agree with Nils
 Breun that such hardcoding in build outputs should be avoided.

 And as currently implemented, `java.enforce` does not actually force the
 port to build using `java.fallback`, because it does not force `JAVA_HOME`
 to point to `java.fallback` rather than some other Java installation.

 `java.enforce` is not used by any ports; it was only ever used in abcl,
 but not since an alternative was found: [https://github.com/macports
 /macports-ports/pull/20089/files#diff-
 0869457f20b83a77c7320b01a92bbc4d7c15feb5489b8bd32880305e94bab285R53]

-- 
Ticket URL: <https://trac.macports.org/ticket/68449#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS


More information about the macports-tickets mailing list