[MacPorts] #69079: rocksdb: test_util/mock_time_env.h:72:16: error: 'TimedWait' marked 'override' but does not override any member functions; test_util/secondary_cache_test_util.cc:41:23: error: unknown type name 'CacheTier'

[MacPorts]

#69079: rocksdb: test_util/mock_time_env.h:72:16: error: 'TimedWait' marked
'override' but does not override any member functions;
test_util/secondary_cache_test_util.cc:41:23: error: unknown type name
'CacheTier'
-------------------------+----------------------
  Reporter:  neverpanic  |      Owner:  stromnov
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:
Resolution:              |   Keywords:
      Port:  rocksdb     |
-------------------------+----------------------

Comment (by neverpanic):

 The build succeeds with this source patch applied:

 {{{
 #!diff
 diff --git a/CMakeLists.txt b/CMakeLists.txt
 index 49868be89..d01ebeebe 100644
 --- a/CMakeLists.txt
 +++ b/CMakeLists.txt
 @@ -552,8 +552,8 @@ if(HAVE_FULLFSYNC)
    add_definitions(-DHAVE_FULLFSYNC)
  endif()

 -include_directories(${PROJECT_SOURCE_DIR})
 -include_directories(${PROJECT_SOURCE_DIR}/include)
 +include_directories(BEFORE ${PROJECT_SOURCE_DIR})
 +include_directories(BEFORE ${PROJECT_SOURCE_DIR}/include)

  if(USE_COROUTINES)
    if(USE_FOLLY OR USE_FOLLY_LITE)
 }}}

 See https://cmake.org/cmake/help/latest/command/include_directories.html
 for the docs. Alternatively, setting
 https://cmake.org/cmake/help/latest/variable/CMAKE_INCLUDE_DIRECTORIES_BEFORE.html#variable:CMAKE_INCLUDE_DIRECTORIES_BEFORE
 without patching the source works as well:

 {{{
 #!diff
 diff --git a/databases/rocksdb/Portfile b/databases/rocksdb/Portfile
 index f67e8a61b71..9982abdeffe 100644
 --- a/databases/rocksdb/Portfile
 +++ b/databases/rocksdb/Portfile
 @@ -51,7 +51,8 @@ configure.args-append \
                      -DROCKSDB_BUILD_SHARED=ON \
                      -DWITH_BZ2=ON \
                      -DWITH_MD_LIBRARY=ON \
 -                    -DWITH_TBB=OFF
 +                    -DWITH_TBB=OFF \
 +                    -DCMAKE_INCLUDE_DIRECTORIES_BEFORE=ON

  if {[string match *gcc* ${configure.compiler}]} {
      # version_set.cc: error:
 'rocksdb::{anonymous}::ManifestPicker::ManifestPicker' defined but not
 used
 }}}

-- 
Ticket URL: <https://trac.macports.org/ticket/69079#comment:4>
MacPorts <https://www.macports.org/>
Ports system for macOS