[MacPorts] #69524: rawstudio does not build again: error: unknown type name 'xmlDocPtr' etc.

[MacPorts]

#69524: rawstudio does not build again: error: unknown type name 'xmlDocPtr' etc.
---------------------------+--------------------------
  Reporter:  barracuda156  |      Owner:  barracuda156
      Type:  defect        |     Status:  assigned
  Priority:  Normal        |  Milestone:
 Component:  ports         |    Version:  2.9.1
Resolution:                |   Keywords:
      Port:  rawstudio     |
---------------------------+--------------------------

Comment (by ryandesign):

 Replying to [comment:5 ryandesign]:
 > rawstudio.h uses the correct trick to tell any C++ code including it
 that the library's functions are C functions that should not be name-
 mangled:
 >
 > {{{#!c
 > #ifdef  __cplusplus
 > extern "C" {
 > #endif
 > }}}
 > {{{#!c
 > #ifdef  __cplusplus
 > } /* extern "c" */
 > #endif
 > }}}

 Ah. The problem is you added [source:macports-
 ports/graphics/rawstudio/files/patch-
 rawstudio.h.diff?rev=64824e63e4b23df8496b740af910263a884e62d0 a patchfile
 to remove those]. Why? (Not one of the 52 comments in the PR that made
 this change appears to have questioned it.)

 I do see that they
 [https://github.com/rawstudio/rawstudio/commit/bb382711b1129fa6895d9c33aede72995086448c
 removed this guard on 20210523] but they
 [https://github.com/rawstudio/rawstudio/commit/12d0d6486d17c26504154ee11c0b5d078200ff3f
 put it back on 20210526].

 If I remove this part of your patch and add
 [https://github.com/rawstudio/rawstudio/pull/90 the fix for the libxml2
 2.12 problem] then the port builds and does not have the denoise.so error
 on startup.

-- 
Ticket URL: <https://trac.macports.org/ticket/69524#comment:6>
MacPorts <https://www.macports.org/>
Ports system for macOS