[23776] trunk/dports/java/pmd

[source_changes at macosforge.org]

Revision: 23776
          http://trac.macosforge.org/projects/macports/changeset/23776
Author:   landonf at macports.org
Date:     2007-04-09 10:59:42 -0700 (Mon, 09 Apr 2007)

Log Message:
-----------
The PMD port wasn't working; this commit:
  - Uses the included .jar dependencies
  - Fixes the bin/pmd script to pass arguments directly to pmd
  - Does not attempt to depend on kaffe (unusable).
  - Claims ownership (plus openmaintainer)

Modified Paths:
--------------
    trunk/dports/java/pmd/Portfile
    trunk/dports/java/pmd/files/pmd

Modified: trunk/dports/java/pmd/Portfile
===================================================================
--- trunk/dports/java/pmd/Portfile	2007-04-09 17:39:44 UTC (rev 23775)
+++ trunk/dports/java/pmd/Portfile	2007-04-09 17:59:42 UTC (rev 23776)
@@ -7,7 +7,7 @@
 
 categories       java lang
 platforms        darwin
-maintainers      nomaintainer at macports.org
+maintainers      landonf at macports.org openmaintainer at macports.org
 
 description      PMD is a Java source code analyzer
 long_description PMD is a Java source code analyzer. It finds unused \
@@ -21,36 +21,34 @@
 use_zip          yes
 
 depends_build    bin:ant:apache-ant
-depends_lib      bin:java:kaffe
-depends_run      port:jaxen \
-                 port:xercesj \
-                 port:saxpath \
-                 port:junit
 
 worksrcdir       ${name}-${version}
 
 post-extract   {
-   file delete ${worksrcpath}/lib/saxpath-1.0-fcs.jar \
-      ${worksrcpath}/lib/xercesImpl-2.0.2.jar \
-      ${worksrcpath}/lib/xmlParserAPIs-2.0.2.jar \
-      ${worksrcpath}/lib/jaxen-core-1.0-fcs.jar \
-      ${worksrcpath}/lib/pmd-2.0.jar
+    # Ensure this gets rebuilt
+    file delete ${worksrcpath}/lib/pmd-${version}.jar
 }
 
 use_configure  no
 
 build.cmd      ant
-build.target   jar
+build.target   dist
 build.dir      ${worksrcpath}/bin
-build.env      CLASSPATH=${prefix}/share/java/junit.jar:${prefix}/share/java/saxpath.jar:${prefix}/share/java/xercesImpl.jar:${prefix}/share/java/xml-apis.jar:${prefix}/share/java/jaxen.jar
 
 destroot {
-   xinstall -m 755 ${filespath}/pmd ${destroot}${prefix}/bin
-   reinplace "s|_PREFIX_|${prefix}|g" ${destroot}${prefix}/bin/pmd
-   xinstall -m 755 -d ${destroot}${prefix}/share/java \
-      ${destroot}${prefix}/share/doc
-   xinstall -m 644 ${worksrcpath}/lib/pmd-${version}.jar \
-      ${destroot}${prefix}/share/java/pmd.jar
-   file copy ${worksrcpath}/docs ${destroot}${prefix}/share/doc/${name}
-   file copy ${worksrcpath}/rulesets ${destroot}${prefix}/share/${name}
+    # Install the wrapper script
+    xinstall -m 755 ${filespath}/pmd ${destroot}${prefix}/bin
+    reinplace "s|_PREFIX_|${prefix}|g" ${destroot}${prefix}/bin/pmd
+
+    # Install jars
+    xinstall -m 755 -d ${destroot}${prefix}/share/pmd
+    file copy ${worksrcpath}/rulesets ${destroot}${prefix}/share/pmd
+    foreach file [glob ${worksrcpath}/lib/*.jar] {
+        xinstall -m 644 ${file} ${destroot}${prefix}/share/pmd/
+    }
+    system "cd ${destroot}${prefix}/share/pmd && ln -s pmd-${version}.jar pmd.jar"
+
+    # Install documentation
+    xinstall -m 755 -d ${destroot}${prefix}/share/doc/pmd
+    file copy ${worksrcpath}/docs ${destroot}${prefix}/share/doc/pmd
 }

Modified: trunk/dports/java/pmd/files/pmd
===================================================================
--- trunk/dports/java/pmd/files/pmd	2007-04-09 17:39:44 UTC (rev 23775)
+++ trunk/dports/java/pmd/files/pmd	2007-04-09 17:59:42 UTC (rev 23776)
@@ -1,11 +1,4 @@
 #!/bin/sh
 PREFIX=_PREFIX_
-if [ $# -ne 3 ]; then
-	echo "Usage $0 source.java format rule"
-	echo " format: html, text, xml"
-	echo " rules: basic, braces, clone, codesize, controversial, coupling, design, favorites, finalizers, imports, javabeans, junit, naming, newrules, scratchpad, strictexception, strings, unusedcode"
-else
-	RULE=${PREFIX}/share/pmd/${3}.xml
-	java -classpath ${PREFIX}/share/java/xml-apis.jar:${PREFIX}/share/java/xercesImpl.jar:${PREFIX}/share/java/saxpath.jar:${PREFIX}/share/java/jaxen-core.jar:${PREFIX}/share/java/pmd.jar net.sourceforge.pmd.PMD $1 $2 ${RULE}
-fi
 
+java -jar ${PREFIX}/share/pmd/pmd.jar "$@"

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.macosforge.org/pipermail/macports-changes/attachments/20070409/740f1c21/attachment.html