[24458] trunk/base/src/darwinports1.0/darwinports.tcl

source_changes at macosforge.org source_changes at macosforge.org
Tue Apr 24 12:08:19 PDT 2007


Revision: 24458
          http://trac.macosforge.org/projects/macports/changeset/24458
Author:   eridius at macports.org
Date:     2007-04-24 12:08:19 -0700 (Tue, 24 Apr 2007)

Log Message:
-----------
Replace some ugly eval-ing with much cleaner subst

Modified Paths:
--------------
    trunk/base/src/darwinports1.0/darwinports.tcl

Modified: trunk/base/src/darwinports1.0/darwinports.tcl
===================================================================
--- trunk/base/src/darwinports1.0/darwinports.tcl	2007-04-24 18:15:09 UTC (rev 24457)
+++ trunk/base/src/darwinports1.0/darwinports.tcl	2007-04-24 19:08:19 UTC (rev 24458)
@@ -78,19 +78,19 @@
 	# Simplify ui_$priority.
 	set nbchans [llength $channels]
 	if {$nbchans == 0} {
-		eval "proc ::ui_$priority {str} {}"
+		proc ::ui_$priority {str} {}
 	} else {
 		set prefix [ui_prefix $priority]
 
 		if {$nbchans == 1} {
 			set chan [lindex $channels 0]
-			eval "proc ::ui_$priority {str} \{ puts $chan \"$prefix\$str\" \}"
+			proc ::ui_$priority {str} [subst -nocommands { puts $chan "$prefix\$str" }]
 		} else {
-			eval "proc ::ui_$priority {str} \{ \n\
-				foreach chan $channels \{ \n\
-					puts $chan \"$prefix\$str\" \n\
-				\} \n\
-			\}"
+			proc ::ui_$priority {str} [subst -nocommands {
+				foreach chan \$channels {
+					puts $chan "$prefix\$str"
+				}
+			}]
 		}
 
 		# Call ui_$priority

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.macosforge.org/pipermail/macports-changes/attachments/20070424/d796898e/attachment.html


More information about the macports-changes mailing list