[24567] users/jberry/mpwa

[source_changes at macosforge.org]

Revision: 24567
          http://trac.macosforge.org/projects/macports/changeset/24567
Author:   jberry at macports.org
Date:     2007-04-28 07:41:06 -0700 (Sat, 28 Apr 2007)

Log Message:
-----------
mpwa: a bit of cleanup; add submitter_notes field to database

Modified Paths:
--------------
    users/jberry/mpwa/app/models/port_pkg.rb
    users/jberry/mpwa/doc/schema-thoughts.sql

Modified: users/jberry/mpwa/app/models/port_pkg.rb
===================================================================
--- users/jberry/mpwa/app/models/port_pkg.rb	2007-04-28 14:27:42 UTC (rev 24566)
+++ users/jberry/mpwa/app/models/port_pkg.rb	2007-04-28 14:41:06 UTC (rev 24567)
@@ -24,6 +24,9 @@
     end
     
     def PortPkg.extract_pkg_meta_from_file(f)
+        # This function parses the xml metadata file from a portpkg,
+        # and creates a canonical internal form for our exclusive use
+        
         meta = PortPkgMeta.new()
         doc = REXML::Document.new(f)
         
@@ -78,19 +81,17 @@
         raise "badpkg: no meta information" if !metaPath.file?
         meta = nil
         File.open(metaPath, "r") { |f| meta = PortPkg.extract_pkg_meta_from_file(f) }
-        puts meta
         
+        # Fill-in portpkg information from metadata
         self.submitted_at = Time.now
         self.submitter = Person.ensure_person_with_email(meta.submitter_email, meta.submitter_name)
-        # TODO: add submitter notes
-        #meta.submitter_notes
+        self.submitter_notes = meta.submitter_notes
        
         self.epoch = meta.epoch
         self.version = meta.version
         self.revision = meta.revision
         
-        puts "revision: #{self.revision}"
-        
+        # Map to, and/or create, a port
         self.port = Port.ensure_port(meta.name, meta)
         
         # Tag with categories

Modified: users/jberry/mpwa/doc/schema-thoughts.sql
===================================================================
--- users/jberry/mpwa/doc/schema-thoughts.sql	2007-04-28 14:27:42 UTC (rev 24566)
+++ users/jberry/mpwa/doc/schema-thoughts.sql	2007-04-28 14:41:06 UTC (rev 24567)
@@ -42,8 +42,9 @@
 
     port_id         bigint not null,
     
+    submitted_at    datetime not null,
     submitter_id    bigint not null, -- one-one: Person
-    submitted_at    datetime not null,
+    submitter_notes text,
     
     epoch           varchar(32),
     version         varchar(32),

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.macosforge.org/pipermail/macports-changes/attachments/20070428/33a02aae/attachment.html