[37981] trunk/base/src/port1.0/portlint.tcl

ryandesign at macports.org ryandesign at macports.org
Tue Jul 1 15:09:20 PDT 2008


Revision: 37981
          http://trac.macosforge.org/projects/macports/changeset/37981
Author:   ryandesign at macports.org
Date:     2008-07-01 15:09:20 -0700 (Tue, 01 Jul 2008)
Log Message:
-----------
portlint.tcl: warn when using "configure {}" instead of "use_configure no"; closes #15806

Modified Paths:
--------------
    trunk/base/src/port1.0/portlint.tcl

Modified: trunk/base/src/port1.0/portlint.tcl
===================================================================
--- trunk/base/src/port1.0/portlint.tcl	2008-07-01 22:09:05 UTC (rev 37980)
+++ trunk/base/src/port1.0/portlint.tcl	2008-07-01 22:09:20 UTC (rev 37981)
@@ -271,6 +271,11 @@
             }
         }
 
+        if {[regexp {(^|\s)configure\s+\{\s*\}} $line]} {
+            ui_warn "Line $lineno should say \"use_configure no\" instead of declaring an empty configure phase"
+            incr warnings
+        }
+
         ### TODO: more checks to Portfile syntax
 
         incr lineno
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.macosforge.org/pipermail/macports-changes/attachments/20080701/715bbcac/attachment.html 


More information about the macports-changes mailing list