[40385] trunk/www/ports.php

[jmpp at macports.org]

Revision: 40385
          http://trac.macports.org/changeset/40385
Author:   jmpp at macports.org
Date:     2008-09-30 00:14:32 -0700 (Tue, 30 Sep 2008)
Log Message:
-----------

 * Don't urlencode() the path to the Portfile in the trac browser as that, somehow, breaks the url;
 * Don't htmlspecialchars the return of our obfuscate_email() function, as that turns valid html syntax into renderable text, thus breaking the html;

I noticed these problems a while back on my local server when I upgraded PHP to its latest 5.2.6 release, so I guess Mac OS Forge is now going through the
same process. But frankly I don't really understand how these problems hadn't surfaced before.

Modified Paths:
--------------
    trunk/www/ports.php

Modified: trunk/www/ports.php
===================================================================
--- trunk/www/ports.php	2008-09-30 04:27:54 UTC (rev 40384)
+++ trunk/www/ports.php	2008-09-30 07:14:32 UTC (rev 40385)
@@ -164,7 +164,7 @@
                  $row = mysql_fetch_assoc($result), $i++) {
 
                 /* Port name and Portfile URL */
-                print "<dt><b><a href=\"${trac_url}browser/trunk/dports/" . urlencode($row['path']) . "/Portfile\">" . htmlspecialchars($row['name'])
+                print "<dt><b><a href=\"${trac_url}browser/trunk/dports/" . $row['path'] . "/Portfile\">" . htmlspecialchars($row['name'])
                 . '</a></b> ' . htmlspecialchars($row['version']) . '</dt>';
                 
                 print '<dd>';
@@ -181,7 +181,7 @@
                     while ($nrow = mysql_fetch_row($nresult)) {
                         if ($primary) { print ' <b>'; }
                         else { print ' '; }
-                        print htmlspecialchars(obfuscate_email($nrow[0]));
+                        print obfuscate_email($nrow[0]);
                         if ($primary) { print '</b>'; }
                         $primary = 0;
                     }
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.macosforge.org/pipermail/macports-changes/attachments/20080930/5fa7edba/attachment.html