[50375] trunk/base/src/port1.0/portlint.tcl

[raimue at macports.org]

Revision: 50375
          http://trac.macports.org/changeset/50375
Author:   raimue at macports.org
Date:     2009-04-29 16:25:28 -0700 (Wed, 29 Apr 2009)
Log Message:
-----------
port1.0/portlint.tcl:
Ignore *.setup commands defined by port groups.

Modified Paths:
--------------
    trunk/base/src/port1.0/portlint.tcl

Modified: trunk/base/src/port1.0/portlint.tcl
===================================================================
--- trunk/base/src/port1.0/portlint.tcl	2009-04-29 23:00:14 UTC (rev 50374)
+++ trunk/base/src/port1.0/portlint.tcl	2009-04-29 23:25:28 UTC (rev 50375)
@@ -245,7 +245,9 @@
             incr warnings
         }
 
-        if {![regexp {^PortSystem|^PortGroup|^version|^(perl5|ruby|haskell|php5extension|php5peclextension).setup} $line]
+        # Check for hardcoded version numbers
+        if {![regexp {^PortSystem|^PortGroup|^version} $line]
+                && ![regexp {^[a-z0-9]+\.setup} $line]
                 && [string first [option version] $line] != -1} {
             ui_warn "Line $lineno seems to hardcode the version number, consider using \${version} instead"
             incr warnings
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.macosforge.org/pipermail/macports-changes/attachments/20090429/f4c65c96/attachment-0001.html>