[51928] trunk/base/src/port1.0/portinstall.tcl

jmr at macports.org jmr at macports.org
Sat Jun 6 10:18:36 PDT 2009


Revision: 51928
          http://trac.macports.org/changeset/51928
Author:   jmr at macports.org
Date:     2009-06-06 10:18:35 -0700 (Sat, 06 Jun 2009)
Log Message:
-----------
clean up portinstall::install_element, including removal of a check whose intent was unnecessary and whose implementation was incorrect

Modified Paths:
--------------
    trunk/base/src/port1.0/portinstall.tcl

Modified: trunk/base/src/port1.0/portinstall.tcl
===================================================================
--- trunk/base/src/port1.0/portinstall.tcl	2009-06-06 16:54:12 UTC (rev 51927)
+++ trunk/base/src/port1.0/portinstall.tcl	2009-06-06 17:18:35 UTC (rev 51928)
@@ -76,18 +76,10 @@
     }
     
     # if the file is a symlink, do not try to set file attributes
-    # if the destination file is an existing directory,
-    # do not overwrite its file attributes
-    if {[file type $src_element] != "link" || [file isdirectory $dst_element]} {
-        set attributes [file attributes $src_element]
-        for {set i 0} {$i < [llength $attributes]} {incr i} {
-            set opt [lindex $attributes $i]
-            incr i
-            set arg [lindex $attributes $i]
-            file attributes $dst_element $opt $arg
-            # set mtime on installed element
-            exec touch -r $src_element $dst_element
-        }
+    if {[file type $src_element] != "link"} {
+        eval file attributes {$dst_element} [file attributes $src_element]
+        # set mtime on installed element
+        file mtime $dst_element [file mtime $src_element]
     }
 }
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.macosforge.org/pipermail/macports-changes/attachments/20090606/6af25a0d/attachment.html>


More information about the macports-changes mailing list